Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for empty options method call #2630

Merged
merged 2 commits into from
Apr 30, 2018
Merged

Fix for empty options method call #2630

merged 2 commits into from
Apr 30, 2018

Conversation

philippjfr
Copy link
Member

When calling the .options method without any arguments it would previously be an error. This PR ensures that condition is handled appropriately.

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: component: options labels Apr 27, 2018
@philippjfr philippjfr added this to the v1.10.2 milestone Apr 27, 2018
@jlstevens
Copy link
Contributor

Looks good to me. Merging.

@jlstevens
Copy link
Contributor

Unless you want to add a unit test first?

@jlstevens
Copy link
Contributor

Added a quick unit test myself. I'll merge once the tests go green.

@philippjfr
Copy link
Member Author

Thanks, I'll go ahead and merge.

@philippjfr philippjfr merged commit 6a4bd34 into master Apr 30, 2018
@philippjfr philippjfr deleted the options_empty branch July 4, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tag: component: options type: bug Something isn't correct or isn't working
Projects
None yet
Milestone
v1.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@philippjfr @jlstevens