Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clabel param #3517

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Add clabel param #3517

merged 2 commits into from
Mar 27, 2019

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Feb 22, 2019

image
image

@philippjfr philippjfr added this to the v1.12.0 milestone Feb 22, 2019
@philippjfr philippjfr added the type: feature A major new feature label Feb 22, 2019
@philippjfr
Copy link
Member

Will merge this after the layout PR goes in.

@jlstevens
Copy link
Contributor

Now layout is merged, I'm happy to see this go in once the merge conflicts are resolved. My only question is whether clabel is the standard name for this (it makes sense to me, just checking we shouldn't be considering some other name....)

Conflicts:
	holoviews/plotting/bokeh/element.py
@jlstevens
Copy link
Contributor

@philippjfr Looks like the merge conflicts are resolved and the tests are passing. If you are happy with the clabel name, I am happy if you want to go ahead and merge this PR.

@philippjfr
Copy link
Member

I'm happy with it.

@jlstevens
Copy link
Contributor

jlstevens commented Mar 27, 2019

Ok, merging then - thanks @ahuang11 for this PR!

@jlstevens jlstevens merged commit ff56900 into master Mar 27, 2019
@philippjfr philippjfr deleted the clabel branch April 29, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A major new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants