Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved datetime handling in utils to avoid type mixing #3530

Merged
merged 5 commits into from
Mar 7, 2019

Conversation

poplarShift
Copy link
Collaborator

I came across two util functions that do not take into account the possibility that different datetime types may be present in an array, such as when comparing axis ranges in overlayed plots (how this can happen in the first place might be worth investigating in more detail at some point). E.g. combining both pandas and numpy datetimes in the same array ruins calls such as to numpy.max etc.

Fixes #3528

@philippjfr
Copy link
Member

Can you think of any tests you could add here? Otherwise I'm happy to merge this.

@poplarShift
Copy link
Collaborator Author

Thanks, I'll think about that. Don't think we'd want to be too strict on what it should be able to handle either.

holoviews/core/util.py Outdated Show resolved Hide resolved
@philippjfr
Copy link
Member

Merging this despite notebook tests failing, the regression is due to changes in param which are fixed in #3474.

@philippjfr philippjfr merged commit 7c73cef into master Mar 7, 2019
@philippjfr philippjfr deleted the nested_datetime branch April 29, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants