-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize VectorFieldPlot #701
Conversation
Clearly a very useful change, and improves consistency. It looks like parameter names (and meanings) have changed, which is fine -- at least then people will get a syntax error if they try to use the old one. When you did something similar to the Points object, generalizing how it treats extra dimensions, it caused a lot of silent and very confusing problems; are those likely to happen from this too? Vector fields are definitely less commonly used than Points, so it can't be as bad as that was, but it would be nice to know whether e.g. vectors will now suddenly start having crazy lengths and colors like Points did, for data that has more dimensions than were previously used. |
That was a change to the sizing behavior which did not change the API. In this case I should simply set the Edit: Also need to update docstrings. |
8af0dbe
to
6305b82
Compare
Ready to merge. |
Looks good and the pr build passed. I would merge if it weren't for this:
Should we try to do something for backwards compatibility before merging? |
Now that I've set the |
The push build won't pass because the PR is slightly behind I think. If you want I can update it but I think it's ready to merge regardless. |
Sounds good to me! |
Ok, given that we think backwards compatibility is retained and this is more flexible, I will merge it now. |
This PR makes the VectorField element and plot mirror other elements more closely in that color and size can be mapped to any arbitrary dimension. It is a backwards compatibility breaking change but makes it more consistent and more powerful. I've used it extensively in my thesis for plots where the angle, magnitude and color are three separate dimensions: