Allow None in keys for partial dimension overlap #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
dynamic_partial_values
branch
from
ebc3e0c
to
5da84f9
Compare
|
Ready to merge, if you agree with the fix. |
|
Although this PR can't be merged right now due to conflicts, I'm happy to discuss this proposal again now that |
|
Let's merge this. It changes nothing but validation code so I don't think there's anything else to worry about. |
|
Ok, I think we should be ok with None values now. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow dimensions with partial overlaps in their dimensions to be displayed together. The code will internally pad any dimension keys that need it with Nones so that the overall object has a consistent set of keys that it can be indexed by. However since NdMappings check that all dimension values must be in the list of Dimension.values the None padding will raise issues. This PR means that None is always allowed as a dimension value.