Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the usage of orix.scalar.Scalar #198

Closed
pc494 opened this issue Jun 4, 2021 · 2 comments
Closed

Consider the usage of orix.scalar.Scalar #198

pc494 opened this issue Jun 4, 2021 · 2 comments
Labels
deprecation Deprecated functionality dev Package maintenance
Milestone

Comments

@pc494
Copy link
Member

pc494 commented Jun 4, 2021

Actually, I avoid using orix.scalar.Scalar wherever I can, because I don't like writing and reading code where the .data is
needed to get the NumPy array. I haven't looked at the reason why we need Scalar, it might a good one, perhaps it enables
us to not check for instance shapes or something similar, but I would be interested in seeing if we can remove completely.

Originally posted by @hakonanes in #197 (comment)

I think this is a broadly fair assessment and worth looking into. The Scalar class can be a nuisance.

@harripj
Copy link
Collaborator

harripj commented Feb 13, 2022

As @hakonanes mentioned this again in #264, it may be worth having a discussion here. From having looked at the code I don't know what benefit we get from the Scalar class other than being an extra (unnecessary) abstraction over a NumPy array and extra .data calls. Personally I would be in favour of trying to remove it.

@hakonanes hakonanes added this to the v1.0.0 milestone Feb 14, 2022
@harripj harripj added deprecation Deprecated functionality dev Package maintenance labels Feb 18, 2022
@harripj harripj mentioned this issue Feb 24, 2022
9 tasks
@hakonanes hakonanes modified the milestones: v1.0.0, v0.9.0 Feb 28, 2022
@harripj
Copy link
Collaborator

harripj commented Mar 7, 2022

Closed by #301 .

@harripj harripj closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecated functionality dev Package maintenance
Projects
None yet
Development

No branches or pull requests

3 participants