You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Actually, I avoid using orix.scalar.Scalar wherever I can, because I don't like writing and reading code where the .data is
needed to get the NumPy array. I haven't looked at the reason why we need Scalar, it might a good one, perhaps it enables
us to not check for instance shapes or something similar, but I would be interested in seeing if we can remove completely.
As @hakonanes mentioned this again in #264, it may be worth having a discussion here. From having looked at the code I don't know what benefit we get from the Scalar class other than being an extra (unnecessary) abstraction over a NumPy array and extra .data calls. Personally I would be in favour of trying to remove it.
Originally posted by @hakonanes in #197 (comment)
I think this is a broadly fair assessment and worth looking into. The Scalar class can be a nuisance.
The text was updated successfully, but these errors were encountered: