Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch release 0.10.1 #390

Closed
5 tasks done
hakonanes opened this issue Sep 28, 2022 · 8 comments
Closed
5 tasks done

Patch release 0.10.1 #390

hakonanes opened this issue Sep 28, 2022 · 8 comments
Labels
bug Something isn't working dev Package maintenance
Milestone

Comments

@hakonanes
Copy link
Member

hakonanes commented Sep 28, 2022

I discovered a bug where indexing/slicing into an already sliced CrystalMap assumed the initial shape (_original_shape) and not the current shape. I'd like to make a patch release 0.10.1.

It's not according to semantic versioning, but I'd like to add deprecation warnings for all references to properties and parameters refering to the z coordinate of a CrystalMap in 0.10.1 as well, with a plan to remove the "functionality" in 0.11. I made a framework for a 3D crystal map when first writing the CrystalMap class, but it is brittle, I don't use it myself (and assume nobody does) and it makes adding functionality to CrystalMap unnecessarily challenging.

I plan to fix #380 for 0.10.1 as well.

If there aren't any objections to the release and these changes, I'll open separate PRs for each of the three changes, merge them in turn when they are all ready, and then release.

Checklist (added by @pc494)

@pc494
Copy link
Member

pc494 commented Sep 29, 2022

I'm fine with "non-semantic" addition of deprecations in patch releases.

@hakonanes
Copy link
Member Author

Thank you, Phillip.

All the four open PRs should go into 0.10.1 after they are reviewed, then. I'll clean up the changelog and bump the release version in #391 once the others are merged onto main.

@pc494
Copy link
Member

pc494 commented Sep 30, 2022

Feel free to review request me on the other PRs

@hakonanes
Copy link
Member Author

Thanks, I’ve done that now.

@pc494
Copy link
Member

pc494 commented Sep 30, 2022

Are you happy to make the release @hakonanes?

@hakonanes
Copy link
Member Author

Yes, thank you for the reviews! I just have to bump the version to 0.10.1.

@hakonanes
Copy link
Member Author

0.10.1 is now available on PyPI. I'd like to complete the release steps for 0.10.1 before yanking 0.10.0 from PyPI.

@hakonanes hakonanes unpinned this issue Oct 3, 2022
@hakonanes
Copy link
Member Author

0.10.1 is now available from conda-forge (for Python >= 3.7 only). So, I'll yank 0.10.0 from PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Package maintenance
Projects
None yet
Development

No branches or pull requests

2 participants