-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch release 0.10.1 #390
Comments
I'm fine with "non-semantic" addition of deprecations in patch releases. |
Thank you, Phillip. All the four open PRs should go into 0.10.1 after they are reviewed, then. I'll clean up the changelog and bump the release version in #391 once the others are merged onto |
Feel free to review request me on the other PRs |
Thanks, I’ve done that now. |
Are you happy to make the release @hakonanes? |
Yes, thank you for the reviews! I just have to bump the version to 0.10.1. |
0.10.1 is now available on PyPI. I'd like to complete the release steps for 0.10.1 before yanking 0.10.0 from PyPI. |
0.10.1 is now available from |
I discovered a bug where indexing/slicing into an already sliced
CrystalMap
assumed the initial shape (_original_shape
) and not the current shape. I'd like to make a patch release 0.10.1.It's not according to semantic versioning, but I'd like to add deprecation warnings for all references to properties and parameters refering to the z coordinate of a CrystalMap in 0.10.1 as well, with a plan to remove the "functionality" in 0.11. I made a framework for a 3D crystal map when first writing the
CrystalMap
class, but it is brittle, I don't use it myself (and assume nobody does) and it makes adding functionality toCrystalMap
unnecessarily challenging.I plan to fix #380 for 0.10.1 as well.
If there aren't any objections to the release and these changes, I'll open separate PRs for each of the three changes, merge them in turn when they are all ready, and then release.
Checklist (added by @pc494)
python_requires>=3.7
packaging metadata #394The text was updated successfully, but these errors were encountered: