-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump oldest supported Python version to 3.7 #347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good to me, just a minor point about the changelog.
I suggest to wait to merge this till tomorrow after the new branches develop
(current master
) and main
are created. (See #243.)
Note that I've renamed the "master" branch to "develop". I hope this doesn't cause any surprises for you @harripj. |
This documentation might be useful. |
This PR is now pointing at the |
I'll merge after getting a cup of coffee ☕ |
As a follow-up to pyxem#347, actually prevent installing on incompatible Python versions when using pip.
As a follow-up to pyxem#347, actually prevent installing on incompatible Python versions when using pip.
Description of the change
As discussed in #343 Python 3.6 is deprecated, but currently used in CI as the oldest supported version. This is preventing implementation of type hinting (as discussed in #338) into the code base as
annotations
from__future__
is only available in Python 3.7+.In this PR the oldest Python version used in CI is bumped to 3.7. A guide for implementing type hints is introduced into the contributing guide.
Progress of the PR
For reviewers
__init__.py
.section in
CHANGELOG.rst
.__credits__
inorix/__init__.py
and in.zenodo.json
.