Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump oldest supported Python version to 3.7 #347

Merged
merged 8 commits into from
May 19, 2022

Conversation

harripj
Copy link
Collaborator

@harripj harripj commented May 18, 2022

Description of the change

As discussed in #343 Python 3.6 is deprecated, but currently used in CI as the oldest supported version. This is preventing implementation of type hinting (as discussed in #338) into the code base as annotations from __future__ is only available in Python 3.7+.

In this PR the oldest Python version used in CI is bumped to 3.7. A guide for implementing type hints is introduced into the contributing guide.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • [n/a] New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • Contributor(s) are listed correctly in __credits__ in orix/__init__.py and in
    .zenodo.json.

@harripj harripj added dev Package maintenance documentation Relates to the documentation labels May 18, 2022
@harripj harripj added this to the v0.10.0 milestone May 18, 2022
@harripj harripj requested review from hakonanes and pc494 May 18, 2022 15:42
Copy link
Member

@hakonanes hakonanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good to me, just a minor point about the changelog.

I suggest to wait to merge this till tomorrow after the new branches develop (current master) and main are created. (See #243.)

CHANGELOG.rst Outdated Show resolved Hide resolved
@hakonanes
Copy link
Member

Note that I've renamed the "master" branch to "develop". I hope this doesn't cause any surprises for you @harripj.

@hakonanes
Copy link
Member

This documentation might be useful.

@harripj
Copy link
Collaborator Author

harripj commented May 19, 2022

This PR is now pointing at the develop branch.

@hakonanes
Copy link
Member

I'll merge after getting a cup of coffee ☕

@hakonanes hakonanes merged commit 567d4a3 into pyxem:develop May 19, 2022
@harripj harripj deleted the remove-support-python3.6 branch May 19, 2022 13:26
sk1p added a commit to sk1p/orix that referenced this pull request Sep 29, 2022
As a follow-up to pyxem#347, actually prevent installing on incompatible Python versions when using pip.
sk1p added a commit to sk1p/orix that referenced this pull request Sep 29, 2022
As a follow-up to pyxem#347, actually prevent installing on incompatible Python versions when using pip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Package maintenance documentation Relates to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants