-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python_requires>=3.7
packaging metadata
#394
Conversation
@sk1p thanks for raising this and providing a fix. I would be in favour of yanking the |
Done! Nowadays possible via the edit button at the top btw. |
I guess I spoke too soon, as it included some unrelated changes. I'll fix this in a bit. |
As a follow-up to pyxem#347, actually prevent installing on incompatible Python versions when using pip.
If it's OK with you @sk1p I'll push some updates to your branch adding you to the credits (taking relevant Zenodo metadata from the same entry in LiberTEM) and add a changelog entry. |
Sure, thanks! |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Description of the change
As a follow-up to #347, actually prevent installing on incompatible Python versions when using pip.
Note that currently, in a Python 3.6 environment,
pip install orix
will install an incompatible version (0.10.0) of orix. This is caused by the missingpython_requires
metadata - without it, the package is seen as compatible with any Python version.Merging and releasing this won't magically fix things for 0.10.0 though - without yanking that release, installing
orix
in an old Python 3.6 environment will continue to pick 0.10.0 and fail at runtime. But adding this and updating once 3.7 support is dropped means the same issue won't come up again.I'll leave the decision about yanking to the maintainers, of course.
Progress of the PR
For reviewers
__init__.py
.section in
CHANGELOG.rst
.__credits__
inorix/__init__.py
and in.zenodo.json
.