Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python_requires>=3.7 packaging metadata #394

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Add python_requires>=3.7 packaging metadata #394

merged 2 commits into from
Sep 30, 2022

Conversation

sk1p
Copy link
Contributor

@sk1p sk1p commented Sep 29, 2022

Description of the change

As a follow-up to #347, actually prevent installing on incompatible Python versions when using pip.

Note that currently, in a Python 3.6 environment, pip install orix will install an incompatible version (0.10.0) of orix. This is caused by the missing python_requires metadata - without it, the package is seen as compatible with any Python version.

Merging and releasing this won't magically fix things for 0.10.0 though - without yanking that release, installing orix in an old Python 3.6 environment will continue to pick 0.10.0 and fail at runtime. But adding this and updating once 3.7 support is dropped means the same issue won't come up again.

I'll leave the decision about yanking to the maintainers, of course.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • [n/a] New functions are imported in corresponding __init__.py.
  • [n/a] New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • Contributor(s) are listed correctly in __credits__ in orix/__init__.py and in
    .zenodo.json.

@harripj
Copy link
Collaborator

harripj commented Sep 29, 2022

@sk1p thanks for raising this and providing a fix. I would be in favour of yanking the 0.10 release once 0.10.1 is released soon (#390), as python 3.6 is unsupported for this release. What do you think @hakonanes @pc494 ?

@hakonanes hakonanes added bug Something isn't working dev Package maintenance labels Sep 29, 2022
@hakonanes hakonanes added this to the v0.10.1 milestone Sep 29, 2022
@hakonanes
Copy link
Member

Thank you very much for bringing this to our attention, @sk1p. Yes, we should yank 0.10.0 once 0.10.1 is out.

@sk1p, since this is a bug fix, can you branch of main instead and make a PR to that branch instead?

@sk1p sk1p changed the base branch from develop to main September 29, 2022 11:16
@sk1p
Copy link
Contributor Author

sk1p commented Sep 29, 2022

since this is a bug fix, can you branch of main instead and make a PR to that branch instead?

Done! Nowadays possible via the edit button at the top btw.

@sk1p
Copy link
Contributor Author

sk1p commented Sep 29, 2022

Done! Nowadays possible via the edit button at the top btw.

I guess I spoke too soon, as it included some unrelated changes. I'll fix this in a bit.

As a follow-up to pyxem#347, actually prevent installing on incompatible Python versions when using pip.
@hakonanes
Copy link
Member

If it's OK with you @sk1p I'll push some updates to your branch adding you to the credits (taking relevant Zenodo metadata from the same entry in LiberTEM) and add a changelog entry.

@sk1p
Copy link
Contributor Author

sk1p commented Sep 29, 2022

If it's OK with you @sk1p I'll push some updates to your branch adding you to the credits (taking relevant Zenodo metadata from the same entry in LiberTEM) and add a changelog entry.

Sure, thanks!

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants