Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Eth::Client::Http/HttpAuth/Ipc#send method to send_request? #171

Closed
d4mk0 opened this issue Dec 4, 2022 · 1 comment · Fixed by #201
Closed

Rename Eth::Client::Http/HttpAuth/Ipc#send method to send_request? #171

d4mk0 opened this issue Dec 4, 2022 · 1 comment · Fixed by #201
Labels
help wanted Extra attention is needed low priority Some day maybe refactor Improving the architecture

Comments

@d4mk0
Copy link
Contributor

d4mk0 commented Dec 4, 2022

Sometimes I try call send method directly i.e. now, I send eth_client.send(:call_payload, ...) to get encoded value for next step.
And @q9f what do you think about it?
Can I rewrite Eth::Client::_child_#send methods to something like send_request?
We also can use object.__send__ method right now, but it's not obvious

@q9f
Copy link
Owner

q9f commented Dec 5, 2022

I've had issues with the design of how we implement send so I would not be opposed to such a change if you want to give this a try.

edit: yes!

@q9f q9f added the refactor Improving the architecture label Dec 5, 2022
@q9f q9f added the help wanted Extra attention is needed label Dec 21, 2022
@q9f q9f added the low priority Some day maybe label Jan 2, 2023
@q9f q9f closed this as completed in #201 Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed low priority Some day maybe refactor Improving the architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants