Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krokiet compiles very long on Windows #1248

Closed
ognevny opened this issue Mar 17, 2024 · 3 comments
Closed

krokiet compiles very long on Windows #1248

ognevny opened this issue Mar 17, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ognevny
Copy link

ognevny commented Mar 17, 2024

compile-time comparisons for czkawka_gui and krokiet (https://github.com/msys2/MINGW-packages/actions/runs/8315051451/job/22752949507?pr=20369)
Finished release [optimized] target(s) in 5m 20s (for cli) + Finished release [optimized] target(s) in 2m 13s
vs.
Finished release [optimized] target(s) in 23m 18s
rustc -vV:
rustc 1.76.0 (07dca489a 2024-02-04) (Rev1, Built by MSYS2 project)
binary: rustc
commit-hash: 07dca489ac2d933c78d3c5158e3f43beefeb02ce
commit-date: 2024-02-04
host: x86_64-pc-windows-gnu
release: 1.76.0
LLVM version: 17.0.6

@ognevny ognevny added the enhancement New feature or request label Mar 17, 2024
@qarmin
Copy link
Owner

qarmin commented Mar 17, 2024

This is expected, because rust have problems with optimizing specific slint structures - rust-lang/rust#121354

There is also workaround, but requires rust nightly - https://github.com/qarmin/czkawka/tree/master/krokiet#compilation

@ognevny
Copy link
Author

ognevny commented Mar 17, 2024

thanks for information!

@qarmin
Copy link
Owner

qarmin commented Sep 30, 2024

Looks that slint changed generated format and now it compiles quite fast with slint 1.8

@qarmin qarmin closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants