Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Q: Compatibility issue with playwright 1.4? #135

Closed
mortelee opened this issue Sep 15, 2020 · 4 comments · Fixed by #136
Closed

Q: Compatibility issue with playwright 1.4? #135

mortelee opened this issue Sep 15, 2020 · 4 comments · Fixed by #136
Assignees

Comments

@mortelee
Copy link

Hi

I'm creating UI tests using playwright 1.4 and use your awesome playwright-video package to capture the results of the UI test.
When I call saveVideo I see some typescript error in my editor. I'm not sure if this is because of using playwright 1.4. Never hurts to ask ;)

image

@jperl
Copy link
Member

jperl commented Sep 15, 2020

@mortelee We are probably going to deprecate this package since Playwright is adding native video recording support. You can try it out in playwright 1.4 https://playwright.dev/#version=v1.4.0&path=docs%2Fapi.md&q=browsertypelaunchoptions--options-videospath

@mortelee
Copy link
Author

@jperl ok, I like the playwright-video package.
Let's see if with playwright we get the same functionality (eg: naming videos and multiple browser window support).
I've tried _videoPath option but nothing is recorded.

@jperl
Copy link
Member

jperl commented Sep 16, 2020

@mortelee We will update playwright-video to playwright@1.4 and we can see if the video capture gets better with playwright@1.5 before deciding to deprecate playwright-video.

@jperl
Copy link
Member

jperl commented Sep 23, 2020

@mortelee The new release is based on playright@1.4.1, let me know if you run into any issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants