Replies: 19 comments
-
|
@LordNyriox labeling by filetype is nice but is not as robust as I'd like to be honest. For example, I would like it to be able to separate TV shows from movies which is where regex of a name (or tracker) is superior. Also I started poking around and it seems like I'll be able to get a hang of this qt thing in a reasonable amount of time (though qtcreator is a jerk so I'm just using cmake). In any case, I'm away for the weekend but I'll see what I can do starting Monday night. |
Beta Was this translation helpful? Give feedback.
-
|
Regex is fine as an additional option to "regular search and match". We support it in RSS feeds IIRC anyway. |
Beta Was this translation helpful? Give feedback.
-
|
So as I'm making my way through this I had a thought... For the category bandwidth settings it's rather easy to implement a per-torrent setting (which I've done already) but I think it would be nice to have a category wide option, sort of like a category specific speed limit (e.g. limit the total upload rate of all torrents in the TV category to 500kb/s). I think that would be a useful feature but the only way I can think of doing that is constantly running a timer and updating the bandwidth limits of individual torrents which just sound somewhat nasty to me. I'm going to leave this feature alone for now but if someone has an idea of how to achieve this cleanly do let me know. |
Beta Was this translation helpful? Give feedback.
-
A wildcard expression can be automatically translated into a regular expression. |
Beta Was this translation helpful? Give feedback.
-
|
Just a small update...
Things left to do:
I'm still thinking about the best way to do automatic categorization rules. You guys are right, regex isn't the most user friendly but it is powerful so I want to find a good compromise. I'm going to take a look at how the RSS feeds do it as @sledgehammer999 suggested once I have some more time. Should have the PR done by this weekend depending on my free time I have to work on this. |
Beta Was this translation helpful? Give feedback.
-
Could you add an option for setting the category via external program call, please? I think a very basic API (a single command line argument is a path to the torrent file, the category name is printed to stdout) would be enough. |
Beta Was this translation helpful? Give feedback.
-
I don't remember the exact machinery in qbt code but an alternative to timer is to just adjust the limits once a category gets assigned/removed from a torrent.
I think this is out of scope for his PR. Plus, qbt isn't supposed to be a command line program. Maybe the WebAPI suffices for this? |
Beta Was this translation helpful? Give feedback.
-
There is a misunderstanding probably. My idea is to give to a user a possibility to detect the category for a torrent in a way he/she wants. An external program may analyse torrent contents, comment, tracker urls and return a category name. This is somewhat similar to the qBt search plugins. I don't ask for a tool to set categories for the torrents that are already "inside" of the qBt session. |
Beta Was this translation helpful? Give feedback.
-
Oh you meant the "run external program on torrent completion" feature. Then I don't have any problem with that. |
Beta Was this translation helpful? Give feedback.
-
Yeah I thought about that but that would only allow you to split the bandwidth evenly among all torrents in the category. What I was thinking is, since not all torrents seed at the same speed all the time, would be to dynamically adjust the limits so that the overall limit is not exceeded (e.g. one torrent seeding at limit or 3 seeding at 1/3 of the limit each). I think I'll leave this to another time (and PR). As for the external program, I'm still not entirely clear on the concept. Correct me if I'm wrong but I thought qbt already had a "run external program on torrent completion" feature and if so I completely think that the program should be passed the torrent's category (if it is set) but it should probably be in another PR. Speaking of separate PRs, I think I will split my work on the ASM enchancements into two PRs. |
Beta Was this translation helpful? Give feedback.
-
Let me make the third attempt :) I'm talking about the automatic categorisation:
A regular expression and the torrent name, as you proposed, is fine, but in order to obtain an ultimate automation, the user has to be able to implement his own categorisation schemes. That is why an external program comes to mind. When a torrent is about to be added to the session, the user-specified external program may be executed to get the category name. |
Beta Was this translation helpful? Give feedback.
-
I didnt know i needed this until you mentioned it, this would be so good for sorting private tracker stuff, television series and system isos.. The main motivation i had for setting up RSS feeds properly was due to the ability to automagically label downloads for easier sorting. |
Beta Was this translation helpful? Give feedback.
-
I think if @pyarmak implements auto-categorization correctly the use of external program won't be needed. Heck, just implementing categories based on regex should be powerful enough. |
Beta Was this translation helpful? Give feedback.
-
|
That's the only thing is keeping me in deluge. I use some regex to autolabel series and movies. But, also, i use another one by specific tracker, so would be nice to include a tracker -> category option. |
Beta Was this translation helpful? Give feedback.
-
|
What's the status of this? I would like a basic feature to auto-assign a torrent's category and / or tags based on its tracker. I'm willing to implement this myself, but I don't want to step on someone else's work if they are actively working on this. The existing PR seems to only be about category-based options and doesn't seem to touch auto-categorization. |
Beta Was this translation helpful? Give feedback.
-
|
@glassez ☝️ |
Beta Was this translation helpful? Give feedback.
-
|
@tgregerson As it stands, I am not actively working on this PR. My initial design plan was indeed to implement automatic regex categorization based on the torrent name and/or tracker. Unfortunately, I don't have time to complete this in a clean and timely manner as I am currently busy with medical school and working on a number of other projects. Besides, if I'm being honest, javascript is my poison haha @glassez That being said, I would be willing to take another look at this if nobody else wants to take over the reins on this one. It would likely not be until at least Christmas break. |
Beta Was this translation helpful? Give feedback.
-
|
Well, how's your medical school as of 2019? I hope you have time to take a fresh look at this feature, which would dramatically improve our lives! Auto-categorization by tracker or regex in name would just save a LOT of rightclicks! |
Beta Was this translation helpful? Give feedback.
-
|
Hi, anyone have any updates here before I take a tackle at this? |
Beta Was this translation helpful? Give feedback.
-
So with the new category system (PR #4784) in place I was thinking it would be nice to include some extra quality of life enhancements e.g. auto-labeling based on torrent name or tracker.
I personally usually just download torrents to a folder and have them automatically added so it would be nice to have them labeled automatically.
I've used this deluge plugin before which is the most robust implementation I've seen so the feature could be modeled after that.
I could take a stab at writing the implementation but I've not used qt before so it might take me a while to get into the swing of things.
What do you guys think?
Beta Was this translation helpful? Give feedback.
All reactions