-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSS functionality in the reference WebUI implementation #12355
Comments
Am currently working on this. Will create a pull request when ready. |
Thank you for this. I was actually researching this an stumbled upon this. This answered my question. You are doing a great job with this program. |
@seprode when you consider it complete enough and ready to test, please announce it and we can be test it via the AtlWebUI |
Since I have implemented all current API functions of the RSS Reader/Auto Downloader, I think it's ready for initial testing (link). When testing as Alternative Web UI marking as read, the list of matching articles and the settings for smart episode filters will only work in v4.2.5 and higher. There are a couple of things I still have on my checklist:
Bugs I know of that that need to be fixed:
Things that I am considering changing/adding:
|
@seprode I tried your webif as an alternate but RSS and all the icons were missing. All I did was clone your repo and point the alt. path to it. If anything more is required than that, please leave proper instructions on how to test. |
@bacon-cheeseburger After cloning and changing to the web-rss branch, copy the icons and folders from src/icons/ to src/webui/www/public/images/ (you need to create the images folder). Then set the alternative webui to src/webui/www. |
If you can fix these, they should be submitted as separate PRs IMO, for easier review. Same for:
If you are willing/manage to implement them. Good luck! |
I already implemented them. Though since my c++ knowledge is very basic I think some parts are bad form. Should I submit the whole branch as a PR or git cherry-pick the API changes and submit those separately? |
Definitely separate PRs. The bug fixes to the API should be 1 PR, the new API features another, and the new WebUI features yet another one. |
That's funny, before I read this I just copied the folder and it somewhat worked, of course without icons. Thanks for this anyway, people was waiting for this for YEARS! EDIT: looks like it was just an ownership issue; I moved the webui to the home of the same user running qbittorrent and now everything works as intended. |
Please append |
Thank you! I really need this 👍 |
Please provide the following information
qBittorrent version and Operating System
Any
If on linux, libtorrent-rasterbar and Qt version
N/A
What is the problem
The reference WebUI implementation does not currently implement the RSS capabilities provided by the WebAPI.
What is the expected behavior
The reference WebUI implementation should implement the RSS capabilities provided by the WebAPI.
Steps to reproduce
N/A
Extra info(if any)
Follow-up to #453.
There are alternate WebUIs that already implement this. Users can use them if they really need the functionality. Contributors can take inspiration from existing code.
The text was updated successfully, but these errors were encountered: