Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS functionality in the reference WebUI implementation #12355

Closed
FranciscoPombal opened this issue Mar 31, 2020 · 12 comments · Fixed by #12557
Closed

RSS functionality in the reference WebUI implementation #12355

FranciscoPombal opened this issue Mar 31, 2020 · 12 comments · Fixed by #12557
Labels
Feature request RSS RSS-related issues/changes WebUI WebUI-related issues/changes

Comments

@FranciscoPombal
Copy link
Member

Please provide the following information

qBittorrent version and Operating System

Any

If on linux, libtorrent-rasterbar and Qt version

N/A

What is the problem

The reference WebUI implementation does not currently implement the RSS capabilities provided by the WebAPI.

What is the expected behavior

The reference WebUI implementation should implement the RSS capabilities provided by the WebAPI.

Steps to reproduce

N/A

Extra info(if any)

Follow-up to #453.

There are alternate WebUIs that already implement this. Users can use them if they really need the functionality. Contributors can take inspiration from existing code.

@FranciscoPombal FranciscoPombal added Feature request WebUI WebUI-related issues/changes RSS RSS-related issues/changes labels Mar 31, 2020
@seproDev
Copy link
Contributor

Am currently working on this. Will create a pull request when ready.
image

@Auguss82
Copy link

Thank you for this. I was actually researching this an stumbled upon this. This answered my question. You are doing a great job with this program.

@WolfganP
Copy link

@seprode when you consider it complete enough and ready to test, please announce it and we can be test it via the AtlWebUI

@seproDev
Copy link
Contributor

seproDev commented Apr 15, 2020

Since I have implemented all current API functions of the RSS Reader/Auto Downloader, I think it's ready for initial testing (link). When testing as Alternative Web UI marking as read, the list of matching articles and the settings for smart episode filters will only work in v4.2.5 and higher.

There are a couple of things I still have on my checklist:

  • Add clear previouslyMatchedEpisodes confirmation dialog
  • Add Matching RSS Article table (requires new API call)
  • Localization support
  • code cleanup

Bugs I know of that that need to be fixed:

  • Rename of rules doesn't work (API broken?)
  • When selecting a folder and an item inside and deleting both, two requests are send with the second one failing

Things that I am considering changing/adding:

  • Resizable RSS view columns
  • The folder structure of RSS feeds is currently flattend and then displayed. A dynamicTable similar to TorrentFilesTable which stores the actual tree would be more elegant. This also applies to the rule matching articles table.
  • Drag and drop moving of feeds/folders

@bacon-cheeseburger
Copy link

@seprode I tried your webif as an alternate but RSS and all the icons were missing. All I did was clone your repo and point the alt. path to it. If anything more is required than that, please leave proper instructions on how to test.

@seproDev
Copy link
Contributor

seproDev commented Apr 19, 2020

@bacon-cheeseburger After cloning and changing to the web-rss branch, copy the icons and folders from src/icons/ to src/webui/www/public/images/ (you need to create the images folder). Then set the alternative webui to src/webui/www.

@FranciscoPombal
Copy link
Member Author

@seprode

Bugs I know of that that need to be fixed

If you can fix these, they should be submitted as separate PRs IMO, for easier review.

Same for:

marking as read, the list of matching articles and the settings for smart episode filters will not work since those require API changes.

If you are willing/manage to implement them.

Good luck!

@seproDev
Copy link
Contributor

@FranciscoPombal

If you are willing/manage to implement them.

I already implemented them. Though since my c++ knowledge is very basic I think some parts are bad form. Should I submit the whole branch as a PR or git cherry-pick the API changes and submit those separately?

@FranciscoPombal
Copy link
Member Author

FranciscoPombal commented Apr 19, 2020

@seprode

I already implemented them. Though since my c++ knowledge is very basic I think some parts are bad form. Should I submit the whole branch as a PR or git cherry-pick the API changes and submit those separately?

Definitely separate PRs. The bug fixes to the API should be 1 PR, the new API features another, and the new WebUI features yet another one.
With respect to the features PR, others may ask you to split it in one PR per feature. But start with one PR for all features and go from there.

@INeDiA
Copy link

INeDiA commented Apr 24, 2020

@bacon-cheeseburger After cloning and changing to the web-rss branch, copy the icons and folders from src/icons/ to src/webui/www/public/images/ (you need to create the images folder). Then set the alternative webui to src/webui/www.

That's funny, before I read this I just copied the folder and it somewhat worked, of course without icons.
Then I saw this comment, copied the icons and now I can't access the RSS tab.
headless qBittorrent v4.1.5 on raspbian, if this is helpful :)

Thanks for this anyway, people was waiting for this for YEARS!

EDIT: looks like it was just an ownership issue; I moved the webui to the home of the same user running qbittorrent and now everything works as intended.
Also I had to rename index.html to login.html to make the new webui accessible after reboot.

@tomyangsh
Copy link

@bacon-cheeseburger After cloning and changing to the web-rss branch, copy the icons and folders from src/icons/ to src/webui/www/public/images/ (you need to create the images folder). Then set the alternative webui to src/webui/www.

That's funny, before I read this I just copied the folder and it somewhat worked, of course without icons.
Then I saw this comment, copied the icons and now I can't access the RSS tab.
headless qBittorrent v4.1.5 on raspbian, if this is helpful :)

Thanks for this anyway, people was waiting for this for YEARS!

Please append /api/v2/app/setPreferences?json=%7B%22alternative_webui_enabled%22:false%7D after URL to disable alternative Web UI.

@MaoJianwei
Copy link

Thank you! I really need this 👍

@qbittorrent qbittorrent locked as resolved and limited conversation to collaborators Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature request RSS RSS-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants