Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privado zip download timeout is too short #2223

Closed
Drmachinegun opened this issue Apr 13, 2024 · 7 comments
Closed

Privado zip download timeout is too short #2223

Drmachinegun opened this issue Apr 13, 2024 · 7 comments

Comments

@Drmachinegun
Copy link

Drmachinegun commented Apr 13, 2024

What's the feature 🧐

Include the option to update the VPN server list from a local .zip

Extra information and references

Im trying to update the privado server list and it times out trying to connect. i copied the output from the update command in to my browser and downloaded the same .zip it was trying to download.
It would be great if i could tell the command to use this zip instead of it trying to go get it
something like this i guess
update-local /pathtozip/ -providers provider.
thanks for you time to make this its been great

Copy link
Contributor

@qdm12 is more or less the only maintainer of this project and works on it in his free time.
Please:

@qdm12
Copy link
Owner

qdm12 commented Apr 29, 2024

The client timeout is set to 10 seconds, how long does the download take for you?? For me it's near instantaneous.
I'm rather short on time and this doesn't seem like a high priority issue, so I would ideally just fix the timeout in the code and close this issue, since I may never find the time to implement such feature.

EDIT: or we could have the http timeout configurable, eventually. But ideally not, one less thing to think about for me and the users 😄

@qdm12 qdm12 changed the title Feature request: Update server list from local .zip Privado zip download timeout is too short Apr 29, 2024
@Drmachinegun
Copy link
Author

It probably takes 10 seconds or so to timeout, I'll find out how to adjust the timer, or maybe learn how to implement the feature myself, sounds fun.
thanks for taking the time to create this

@qdm12
Copy link
Owner

qdm12 commented May 5, 2024

I'll find out how to adjust the timer, or maybe learn how to implement the feature myself, sounds fun.

I would go against loading data from a zip file, since not all VPN providers give a zip file. It feels it would introduce unneeded complexity and long term support. Also, it's strange it takes > 10 seconds to download that zip file, is your internet bandwidth very slow (check on fast.com) or internet latency very high? The zip file is 600KB, it should download within 10 seconds in pretty much all cases I can think of, except if you run internet infrastructure from the 90s 🤔

@Drmachinegun
Copy link
Author

Internet infrastructure and speed is fine, I got it up and working using slickvpn but it expires next month, only privado gives me problems. I'll adjust the timer when I get around to messing with it again. Thanks again for your time

@qdm12
Copy link
Owner

qdm12 commented May 9, 2024

Ok thanks for letting me know, closing this for now.

@qdm12 qdm12 closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

Closed issues are NOT monitored, so commenting here is likely to be not seen.
If you think this is still unresolved and have more information to bring, please create another issue.

This is an automated comment setup because @qdm12 is the sole maintainer of this project
which became too popular to monitor issues closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants