Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea to avoid escaping chars #684

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Mar 16, 2022

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #684 (fa451cc) into master (0b17381) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

❗ Current head fa451cc differs from pull request most recent head 19fd340. Consider uploading reports for the commit 19fd340 to get more accurate results

@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
- Coverage   90.68%   90.58%   -0.10%     
==========================================
  Files         458      457       -1     
  Lines       15817    15782      -35     
  Branches     2655     2649       -6     
==========================================
- Hits        14343    14296      -47     
- Misses        943      955      +12     
  Partials      531      531              
Flag Coverage Δ
all 90.58% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....foundation.writemeta/Helpers/ExifToolCmdHelper.cs 93.12% <0.00%> (-2.02%) ⬇️
...y.foundation.writemeta/Services/ExifToolService.cs 63.63% <ø> (ø)
...rsky.feature.geolookup/Services/GeoFileDownload.cs 61.76% <0.00%> (-20.59%) ⬇️
starsky/starskygeocli/Program.cs 90.00% <0.00%> (-10.00%) ⬇️
...arsky/starsky.feature.geolookup/Services/GeoCli.cs 87.14% <0.00%> (-4.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43e4d71...19fd340. Read the comment docs.

@qdraw qdraw added this to the Release 0.5.x (after 0) milestone Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant