Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh Render Extent Settings #59305

Closed
wants to merge 25 commits into from
Closed

Conversation

JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Nov 1, 2024

Description

This PR brings to renderer for Mesh Contours option to set renderer Min Max based on extent (specific canvas, changing canvas) in the same way as renderers for Raster Layer.

Besides that minimumMaximumActiveScalarDataset( const QgsRectangle &extent, const QgsMeshDatasetIndex &datasetIndex, double &min, double &max ) is added to MeshLayer to obtain Min Max from specific Scalar Dataset Index for given extent.

@github-actions github-actions bot added this to the 3.42.0 milestone Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit e8255e8)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit e8255e8)

@DelazJ DelazJ added Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Nov 7, 2024
@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 21, 2024
@qgis qgis deleted a comment from github-actions bot Nov 22, 2024
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 22, 2024
Copy link
Contributor

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JanCaha Can you update your top message with a screenshot for the docs and changelog, please? Thanks.

UserDefined, //User defined Min Max values
WholeMesh, // Values from whole mesh
FixedCanvas, //Fixed Min Max Values set from canvas
InteractiveFromCanvas, //Constantly updated from extent of the canvas is used to compute statistics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something missing in this sentence?

src/core/mesh/qgsmeshrenderersettings.h Outdated Show resolved Hide resolved
src/core/mesh/qgsmeshrenderersettings.h Outdated Show resolved Hide resolved
tests/src/core/testqgsmeshlayer.cpp Outdated Show resolved Hide resolved
src/core/mesh/qgsmeshrenderersettings.h Outdated Show resolved Hide resolved
fix typo

Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
JanCaha and others added 3 commits November 22, 2024 15:30
fix texts

Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
fix string

Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
fix string

Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
@nyalldawson
Copy link
Collaborator

@JanCaha have you seen #59444 ? The current way the raster layer handles extent based rendering is fragile, and is being reworked in that PR. Are you able to adapt to the same approach as is used there?

@JanCaha
Copy link
Contributor Author

JanCaha commented Nov 25, 2024

@nyalldawson I did not see that one. Actually this PR is older then the raster one :-)

It should not be a problem to adapt to that PR. Let me wait for #59444 to be merged and then rework this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog Items that are queued to appear in the visual changelog - remove after harvesting Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants