Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance the ability to customize icons for QgsPluginLayer #59537

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hxbb00
Copy link
Contributor

@hxbb00 hxbb00 commented Nov 20, 2024

Description

Enhance the ability to customize icons for QgsPluginLayer

@github-actions github-actions bot added this to the 3.42.0 milestone Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit bf41f6b)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit bf41f6b)

src/core/qgsiconutils.cpp Outdated Show resolved Hide resolved
src/core/qgspluginlayer.cpp Outdated Show resolved Hide resolved
src/core/qgspluginlayer.h Outdated Show resolved Hide resolved
@nyalldawson
Copy link
Collaborator

@hxbb00 you'll just need to run the scripts/sipify_all.sh script now in order to update the Python bindings (sip files). That'll fix the failing test.

@hxbb00
Copy link
Contributor Author

hxbb00 commented Nov 29, 2024

Okay, I've fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants