Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script is adding every other offer, not each one #2

Open
a1ch3mist opened this issue Sep 9, 2020 · 6 comments
Open

Script is adding every other offer, not each one #2

a1ch3mist opened this issue Sep 9, 2020 · 6 comments

Comments

@a1ch3mist
Copy link

Using Chrome devtools

The script is adding every other offer, not each one. Also seems to occasionally skip more than every other one.

@qibinlou
Copy link
Owner

@a1ch3mist thanks for reporting! Will take a look at the issue

@qibinlou
Copy link
Owner

@a1ch3mist could you help try out latest version https://github.com/qibinlou/Amex-Offers-Helper/blob/master/index.js ?

Also FYI, there are two categories of offer buttons on the offer list page 1) no-action-required offers 2) action-required offers such as redirecting to trycaviar.com to create an account. This script only help users register no-action-required offers.

@a1ch3mist
Copy link
Author

It's still missing some. Perhaps you have to delay between each click? AMEX Offers takes a second or two to "register" the click. Tried on an account with 96 offers available.

A 2nd run caught the rest of them.

I did catch a "Sorry About That!" error quickly on the Web page while I was watching it add, so maybe there are occasional server errors?

Is there a 100-limit on the actual added offers as well, or just on the available?

@qibinlou
Copy link
Owner

@a1ch3mist the script waits 2s after each click on Add To Card button so there shouldn't be a rate limiting by Amex (at least when I tested it on my account for multiple times). I believe Amex caps the available offers to at most 100 per card in my experience.

Regarding It's still missing some., to clarify, do those missed ones have Add To Card text or other labels? The script will only automate the clicks on buttons with Add To Card label because those buttons map to no-action-required offers.

@a1ch3mist
Copy link
Author

Correct, those were offers with the "Add to Card" button. I understand the difference like you said. 2s might not be enough time. I've seen some take longer than that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@qibinlou @a1ch3mist and others