Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequences with different frequencies are not separated #1069

Open
jevillegasdatTII opened this issue Oct 9, 2024 · 3 comments · Fixed by #993
Open

Sequences with different frequencies are not separated #1069

jevillegasdatTII opened this issue Oct 9, 2024 · 3 comments · Fixed by #993
Assignees

Comments

@jevillegasdatTII
Copy link

def separate_overlapping_pulses(self): # -> dict((int,int): PulseSequence):

When sending two pulse sequences over the same channel, provided they don't overlap in time, they are not getting separated into different sequencers. Consequently, the frequency of the first pulse defines the nco frequency for the sequence and all the following pulses use the same frequency irrespective of their settings. For instance, the following code generates the attached sequences sent to qblox.

sequence = PulseSequence()
rx_pulse_q0 = platform.create_RX_pulse(0, start = 0)
rx_pulse_q1 = platform.create_RX_pulse(1, start = 0)
sequence.add(rx_pulse_q0)
sequence.add(rx_pulse_q1)
cr_pulse = platform.create_RX_pulse(1, start = rx_pulse_q1.finish)
cr_pulse.frequency = rx_pulse_q0.frequency
cr_pulse.duration = 1000
sequence.add(cr_pulse)

Z_qcm_rf0_sequencer1_sequence.json
Z_qcm_rf0_sequencer0_sequence.json
Z_qcm_rf0_snapshot.json

Notably, only two sequencers are created, where we need three (channel 2 with two different frequencies and channel one a single one).

@jevillegasdatTII
Copy link
Author

jevillegasdatTII commented Oct 9, 2024

Possble fix in commit 94bed20

@hay-k
Copy link
Contributor

hay-k commented Oct 9, 2024

@jevillegasdatTII I will take a look at your commits, but for the future can you please not push any commits directly to the branch qblox-ad-hoc-features, and instead create a PR pointing to that branch.

@jevillegasdatTII
Copy link
Author

Absolutely, sorry. :(

@hay-k hay-k linked a pull request Oct 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants