Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep pg mysql sqlite the same #124

Merged
merged 4 commits into from
Oct 19, 2023
Merged

keep pg mysql sqlite the same #124

merged 4 commits into from
Oct 19, 2023

Conversation

Jacyking
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0303216) 39.95% compared to head (34687c6) 39.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   39.95%   39.88%   -0.08%     
==========================================
  Files          22       22              
  Lines        2868     2856      -12     
==========================================
- Hits         1146     1139       -7     
+ Misses       1722     1717       -5     
Files Coverage Δ
include/utility.hpp 98.70% <ø> (+0.80%) ⬆️
tests/test_ormpp.cpp 95.38% <100.00%> (+0.16%) ⬆️
include/mysql.hpp 81.67% <88.23%> (+1.18%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jacyking Jacyking merged commit 54565a5 into qicosmos:master Oct 19, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants