Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint linter: automatically infer the execution directory #207

Closed
CarlJi opened this issue Jun 27, 2024 · 2 comments
Closed

golangci-lint linter: automatically infer the execution directory #207

CarlJi opened this issue Jun 27, 2024 · 2 comments

Comments

@CarlJi
Copy link
Contributor

CarlJi commented Jun 27, 2024

background:

😱🚀 Linter: golangci-lint 
Repo: goplus/builder 
PR:   https://github.com/goplus/builder/pull/615 
Event: d4605c30-3469-11ef-83a5-c58febdb5641 
Unexpected: level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

In some monorepos, Go code is not placed in the main directory, and the current golangci-lint cannot automatically discover it.
Reviewbot currently supports custom workDir, but it would be better if it could be automatically determined.

@CarlJi
Copy link
Contributor Author

CarlJi commented Jun 28, 2024

FYI: golangci/golangci-lint#825

@CarlJi
Copy link
Contributor Author

CarlJi commented Jul 12, 2024

fixed by #235

@CarlJi CarlJi closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant