Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change usages of index(t) to a more robust isclose() #11

Open
haggaila opened this issue Dec 1, 2022 · 1 comment
Open

Change usages of index(t) to a more robust isclose() #11

haggaila opened this issue Dec 1, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@haggaila
Copy link
Collaborator

haggaila commented Dec 1, 2022

index(t) is used twice in plot_routines.py and should be replaced by isclose with a relative precision of 0.01 of the difference of two consecutive observable time entries.
@haggaila haggaila changed the title Change usages of index(t) to a more robust isclose Change usages of index(t) to a more robust isclose() Dec 1, 2022
@haggaila haggaila added the good first issue Good for newcomers label Dec 1, 2022
@robotAstray robotAstray mentioned this issue Aug 4, 2023
Open
@robotAstray
Copy link

Hello @haggaila I tried to make the changes to plot_routines.py to resolve this issue. Let me know if I need to make any corrections. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haggaila @robotAstray