Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage modular DriverResult directly on Driver level #264

Closed
mrossinek opened this issue Jul 6, 2021 · 0 comments · Fixed by #303
Closed

Leverage modular DriverResult directly on Driver level #264

mrossinek opened this issue Jul 6, 2021 · 0 comments · Fixed by #303
Assignees

Comments

@mrossinek
Copy link
Member

What is the expected enhancement?

The third (and final) step of #148 suggests to replace the return objects for all qiskit_nature.drivers with the new modular Property framework. I.e.:

class BaseDriver:
    def run(self) -> DriverResult:
        ...

class FermionicDriver:
    def run(self) -> ElectronicDriverResult:
        ...

class BosonicDriver:
    def run(self) -> VibrationalDriverResult:
        ...

⚠️ Names not final!

The implementation of these CompositeProperty objects (as proposed in #263) allows a straight forward migration using the from_legacy_driver_result methods.

The aforementioned PR also lists some more details which need to be addressed as part of closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant