-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating the TwoQubitReduction
into the ParityMapper
#973
Comments
I can contribute here also |
This PR is no longer blocked by #9140 from qiskit-terra so I'll start working on a draft. |
That is indeed a good point! I'm wondering whether we should then generalize the naming and find something better than |
The |
What should we add?
As outlined in #967 we want to extract the
TwoQubitReduction
fromqiskit.opflow
into theParityMapper
which is the only mapper that actually supports this hard-coded symmetry.To achieve this, I envision an API similar to the following:
We need to default the
two_qubit_reduction
to False because we do not know thenum_particles
by default.Providing the
num_particles
at initialization time ensures that the mapper can be used right away. The downside is that this makes it stateful for the current problem.I would also be open to discussing the following API (which I personally even prefer):
The idea here is that if
num_particles
is provided we enable the reduction and if it isNone
we do not. Simple and less redundant 👍Implementation of this issue is blocked by Qiskit/qiskit#9140 because we would want to immediately use the new
SparsePauliOp
-basedZ2Symmetries
👍The text was updated successfully, but these errors were encountered: