Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsers to output Messages #1234

Open
brynary opened this issue Nov 27, 2024 · 0 comments
Open

Allow parsers to output Messages #1234

brynary opened this issue Nov 27, 2024 · 0 comments

Comments

@brynary
Copy link
Member

brynary commented Nov 27, 2024

We have a data transfer object called Message which is for diagnostics. For example, we output a Message of level error if a plugin returns too many issues and we cut them off.

However, a trait Parser today returns Result<Vec<Issue>>, so it is not possible to emit Messages from the parser itself. We should extend the Parser interface to return a new struct ParserResult which has both a Vec<Issue> and Vec<Message>

@brynary brynary changed the title Bug: Allow parsers to output Messages Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant