Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add ISO-specific keys in configurator #768

Open
IonicOwl opened this issue Jun 29, 2020 · 5 comments
Open

Unable to add ISO-specific keys in configurator #768

IonicOwl opened this issue Jun 29, 2020 · 5 comments

Comments

@IonicOwl
Copy link

I'm trying to flesh out an ISO keyboard layout on the configurator, but despite using the keys in the ISO/JIS tab, when I drag them up to the keymap, they show the ANSI key instead.

In the example below, dragging the KC_2 key up to its position on the top row shows the "2/@" key, instead of the "2/"" key that I'd expect.

image

This also occurs with the KC_3 (should be "3/£), KC_GRV and KC_QUOT keys.

Also, since the AltGr key isn't under the ISO tab, am I right in assuming that I should be using the RALT(kc) key under the Quantum tab for accessing graph/accent keys?

@yanfali
Copy link
Collaborator

yanfali commented Jun 29, 2020

@IonicOwl this is a good catch, it's more of a visual oversight than an actual bug. Your operating system is responsible for mapping the ANSI based HID codes onto the locale. I think to fix this it mostly requires fixing up the keycodes for the ISO keymap programmatically to display the correct codes. No actual keycodes need to change.

@yanfali
Copy link
Collaborator

yanfali commented Jun 29, 2020

Can you send a list of the keys that need updating? or are the ones in the bug exhaustive?

@noroadsleft
Copy link
Member

Also, since the AltGr key isn't under the ISO tab, am I right in assuming that I should be using the RALT(kc) key under the Quantum tab for accessing graph/accent keys?

Actually, I noticed that the AltGr key was missing from the ISO tab a while back, and I think I may have a branch that adds it.

Gimme some time and I'll dive in to that. The rest of this is as yanfali said – a visual oversight, rather than a bug.

@IonicOwl
Copy link
Author

IonicOwl commented Jun 30, 2020

Can you send a list of the keys that need updating? or are the ones in the bug exhaustive?

Those are the only ones that need adding for my layout. I'm only building a 60% and I'm pretty sure everything on the navigation and number clusters are identical between ISO and ANSI layouts anyway.

EDIT: Strangely I was able to add the "\ |" key (right of the narrower left-shift key on ISO boards) with no problem.

@noroadsleft
Copy link
Member

#770 will add the Alt Gr key to the ISO tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants