From 37a4b53c4f51b66992e687b5012c83df9cc6b138 Mon Sep 17 00:00:00 2001 From: Ryan Date: Thu, 30 Apr 2020 16:24:13 +1000 Subject: [PATCH] BACKLIGHT_ON_STATE config.h fixes (#8862) --- keyboards/amjkeyboard/amj66/config.h | 1 - keyboards/duck/orion/v3/config.h | 1 - keyboards/gray_studio/cod67/config.h | 1 + keyboards/gray_studio/cod67/readme.md | 4 ---- keyboards/handwired/aek64/config.h | 3 --- keyboards/handwired/bdn9_ble/config.h | 1 - keyboards/staryu/config.h | 1 - keyboards/tokyo60/config.h | 1 - keyboards/xd68/config.h | 1 + keyboards/xd75/config.h | 1 + 10 files changed, 3 insertions(+), 12 deletions(-) diff --git a/keyboards/amjkeyboard/amj66/config.h b/keyboards/amjkeyboard/amj66/config.h index 5569bcd919e0..ac10f7e35e86 100644 --- a/keyboards/amjkeyboard/amj66/config.h +++ b/keyboards/amjkeyboard/amj66/config.h @@ -43,7 +43,6 @@ along with this program. If not, see . #define BACKLIGHT_LEVELS 3 #define BACKLIGHT_BREATHING #define BREATHING_PERIOD 6 -#define BACKLIGHT_ON_STATE 1 /* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */ #define DEBOUNCE 5 diff --git a/keyboards/duck/orion/v3/config.h b/keyboards/duck/orion/v3/config.h index b04729712ee5..ce64431afca0 100644 --- a/keyboards/duck/orion/v3/config.h +++ b/keyboards/duck/orion/v3/config.h @@ -43,7 +43,6 @@ along with this program. If not, see . #define BACKLIGHT_PINS { B1, B2, B3, E6 } #define BACKLIGHT_LED_COUNT 4 #define BACKLIGHT_LEVELS 10 -#define BACKLIGHT_ON_STATE 1 #define RGBLIGHT_ANIMATIONS #define RGB_DI_PIN D6 diff --git a/keyboards/gray_studio/cod67/config.h b/keyboards/gray_studio/cod67/config.h index 2231827ba65d..238869c2c3dc 100644 --- a/keyboards/gray_studio/cod67/config.h +++ b/keyboards/gray_studio/cod67/config.h @@ -52,6 +52,7 @@ along with this program. If not, see . * https://docs.qmk.fm/#/feature_backlight?id=timer-assisted-pwm-implementation */ #define BACKLIGHT_PIN D4 +#define BACKLIGHT_ON_STATE 0 #define RGB_DI_PIN B2 #ifdef RGB_DI_PIN diff --git a/keyboards/gray_studio/cod67/readme.md b/keyboards/gray_studio/cod67/readme.md index 6e79ffec4a28..b7a9a8028ad7 100644 --- a/keyboards/gray_studio/cod67/readme.md +++ b/keyboards/gray_studio/cod67/readme.md @@ -39,7 +39,3 @@ After putting your COD67 in bootloader mode, it will show up as a drive. * Drag and drop your new `COD67.BIN` to the drive. * Wait a few seconds for it to write. The caps lock LED flashes rapidly while writing. * Press the `Esc` key or eject the drive in Finder to reset the board. You are now ready to type! - -## Notes - -The backlight pin is attached to a non PWM pin `D4` so the backlight is only on/off. diff --git a/keyboards/handwired/aek64/config.h b/keyboards/handwired/aek64/config.h index a072d562a783..f10cd69dd5a9 100644 --- a/keyboards/handwired/aek64/config.h +++ b/keyboards/handwired/aek64/config.h @@ -27,9 +27,6 @@ along with this program. If not, see . #define PRODUCT AEK64 #define DESCRIPTION QMK keyboard firmware for AEK64 handwired -/* Define the backlight */ -/*#define BACKLIGHT_ON_STATE 1*/ - /* key matrix size */ #define MATRIX_ROWS 5 #define MATRIX_COLS 14 diff --git a/keyboards/handwired/bdn9_ble/config.h b/keyboards/handwired/bdn9_ble/config.h index 8db9253dd459..e6762406a05a 100644 --- a/keyboards/handwired/bdn9_ble/config.h +++ b/keyboards/handwired/bdn9_ble/config.h @@ -41,7 +41,6 @@ along with this program. If not, see . #define BACKLIGHT_PIN F6 // #define BACKLIGHT_BREATHING #define BACKLIGHT_LEVELS 5 -#define BACKLIGHT_ON_STATE 1 /* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */ #define DEBOUNCE 5 diff --git a/keyboards/staryu/config.h b/keyboards/staryu/config.h index dc7353fcce2d..dbf2b867eae3 100755 --- a/keyboards/staryu/config.h +++ b/keyboards/staryu/config.h @@ -65,7 +65,6 @@ along with this program. If not, see . #define BACKLIGHT_PINS { C2, C7, D5, D6, B0 } #define BACKLIGHT_LED_COUNT 5 #define BACKLIGHT_LEVELS 10 -#define BACKLIGHT_ON_STATE 1 /* Set 0 if debouncing isn't needed */ #define DEBOUNCE 5 diff --git a/keyboards/tokyo60/config.h b/keyboards/tokyo60/config.h index 79b904da1b9c..e22242c8f62e 100644 --- a/keyboards/tokyo60/config.h +++ b/keyboards/tokyo60/config.h @@ -18,7 +18,6 @@ #define BACKLIGHT_PIN B7 #ifdef BACKLIGHT_PIN #define BACKLIGHT_LEVELS 6 -//#define BACKLIGHT_ON_STATE 1 #endif /* COL2ROW or ROW2COL */ diff --git a/keyboards/xd68/config.h b/keyboards/xd68/config.h index f0a78c1fd2d0..c86bb56225d6 100644 --- a/keyboards/xd68/config.h +++ b/keyboards/xd68/config.h @@ -52,6 +52,7 @@ along with this program. If not, see . #define BACKLIGHT_LEVELS 6 #define BACKLIGHT_BREATHING #define BREATHING_PERIOD 6 +#define BACKLIGHT_ON_STATE 0 /* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */ #define DEBOUNCE 5 diff --git a/keyboards/xd75/config.h b/keyboards/xd75/config.h index 7f8b71c45c97..b3a1882becd1 100644 --- a/keyboards/xd75/config.h +++ b/keyboards/xd75/config.h @@ -51,6 +51,7 @@ along with this program. If not, see . #define BACKLIGHT_PIN F5 #define BACKLIGHT_LEVELS 6 +#define BACKLIGHT_ON_STATE 0 /* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */ #define DEBOUNCE 5