Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Keyboard freezes after a few keystrokes #12536

Closed
mvuksano opened this issue Apr 10, 2021 · 1 comment
Closed

[Bug] Keyboard freezes after a few keystrokes #12536

mvuksano opened this issue Apr 10, 2021 · 1 comment

Comments

@mvuksano
Copy link

After a few keystrokes, keyboard does not produce any more key presses.

Describe the Bug

I am using Massdrop OLKB keyboard with latest firmware. My intent was to create a log of key press events so I can further analyze it and create a heat map of my keyboard usage.

System Information

  • Keyboard: Massdrop OLKB
    • Revision (if applicable): rev6
    • CPU: ARM STM32
  • Operating system: MacOS X and Linux (I have not tried Windows)
  • AVR GCC version: avr-gcc (Fedora 10.2.0-1.fc33) 10.2.0
  • ARM GCC version: arm-none-eabi-gcc (Fedora 10.2.0-2.fc33) 10.2.0
  • QMK Firmware version: 0.12.32
  • Any keyboard related software installed? None

Additional Context

Following is the diff of the changes that cause the keyboard to stop responding. Without applying this diff the keyboard works as expected.

diff --git a/keyboards/planck/keymaps/marko/keymap.c b/keyboards/planck/keymaps/marko/keymap.c
index ab9899edb..7316e2697 100644
--- a/keyboards/planck/keymaps/marko/keymap.c
+++ b/keyboards/planck/keymaps/marko/keymap.c
@@ -17,6 +17,10 @@
 #include QMK_KEYBOARD_H
 #include "muse.h"
 
+#ifdef CONSOLE_ENABLE
+#include "print.h"
+#endif
+
 
 enum planck_layers {
   _QWERTY,
@@ -181,6 +185,11 @@ layer_state_t layer_state_set_user(layer_state_t state) {
 }
 
 bool process_record_user(uint16_t keycode, keyrecord_t *record) {
+  #ifdef CONSOLE_ENABLE
+    if (record->event.pressed) {
+      uprintf("0x04X,%u,%u,%u\n", keycode, record->event.key.row, record->event.key.col, get_highest_layer(layer_state));
+    }
+  #endif
   switch (keycode) {
     case QWERTY:
       if (record->event.pressed) {
diff --git a/keyboards/planck/keymaps/marko/rules.mk b/keyboards/planck/keymaps/marko/rules.mk
index 1b5789717..35cc9d5ef 100644
--- a/keyboards/planck/keymaps/marko/rules.mk
+++ b/keyboards/planck/keymaps/marko/rules.mk
@@ -1,3 +1,4 @@
 SRC += muse.c
 
 KEY_LOCK_ENABLE = yes
+CONSOLE_ENABLE = yes
@zvecr
Copy link
Member

zvecr commented Apr 10, 2021

Duplicate of #5631

@zvecr zvecr marked this as a duplicate of #5631 Apr 10, 2021
@zvecr zvecr closed this as completed Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants