Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XAP] implement "secure mode" #15627

Closed
tzarc opened this issue Dec 28, 2021 · 2 comments
Closed

[XAP] implement "secure mode" #15627

tzarc opened this issue Dec 28, 2021 · 2 comments

Comments

@tzarc
Copy link
Member

tzarc commented Dec 28, 2021

XAP Task Info

Original Issue
Original spec document
Current XAP Definitions
Current XAP Generated Docs
Placeholder PR

Description

Any work in this area needs to be discussed with QMK Collaborators first.

XAP needs to support a "secure mode" for any critical pieces of functionality. Changes to keymaps or rebooting into bootloader cannot be made available unless an "unlock sequence" is initiated and performed first.

  • Will need to be based on matrix positioning rather than keycodes
  • Look at Vial for inspiration here
  • Work out what needs to be intercepted and where
  • Work out how to define the key sequence
    • Start from info.json, add support in the data-driven definitions, jsonschema etc.
    • Work out how to translate the defined key sequence into appropriate C code
  • Need to handle some sort of inactivity timeout to get back to keyboard functionality
  • Need to handle some sort of "escape" to get back to keyboard functionality
    • Will need to be based on matrix positioning rather than keycodes
  • Need to add a broadcast message for secure mode entry, secure mode exit
  • Need to add a route to query secure mode status
  • Need to add a generic error if a secure-mode route is executed when not unlocked
@tzarc tzarc added enhancement help wanted xap XAP-related issues/PRs labels Dec 28, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label Apr 16, 2022
@stale stale bot removed the stale Issues or pull requests that have become inactive without resolution. label Apr 16, 2022
@tzarc
Copy link
Member Author

tzarc commented Oct 7, 2022

Confirmed working with XAP interactive shell on RP2040.

@tzarc tzarc closed this as completed Oct 7, 2022
@tzarc tzarc added this to XAP MVP Sep 25, 2023
@tzarc tzarc moved this to Done in XAP MVP Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant