Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XAP] First boot initialisation #17455

Closed
zvecr opened this issue Jun 22, 2022 · 3 comments
Closed

[XAP] First boot initialisation #17455

zvecr opened this issue Jun 22, 2022 · 3 comments
Labels
enhancement in progress xap XAP-related issues/PRs

Comments

@zvecr
Copy link
Member

zvecr commented Jun 22, 2022

XAP Task Info

Original Issue
Original spec document
Current XAP Definitions
Current XAP Generated Docs
Placeholder PR

Description

Any work in this area needs to be discussed with QMK Collaborators first.

Bind eeprom reset logic so that dynamic keymap is populated.

  • reset condition?
    • enabled features?
  • via -> stores date to detect "significant" firmware change
  • xap version?
  • introduce version for dynamic keymap format?
@zvecr zvecr added enhancement xap XAP-related issues/PRs labels Jun 22, 2022
@tzarc
Copy link
Member

tzarc commented Jun 22, 2022

Maybe now with the introspection capabilities, we can use a CRC over the keymap and encodermap and use that instead of the date?

@zvecr
Copy link
Member Author

zvecr commented Jun 27, 2022

hash at runtime would work, be it going to burn more cycles on boot. Would be a little more targeted which has both upsides and downsides.

Implemented at 28855f6:

  • variable keycode IDs depending on enabled features
    • enabled features somewhat need to be taken into account with the current keycode implementation
    • less of an issue with DD keycodes?
      • include keycode version in hash?

Maybe something like 2592402 at build time?

  • maybe too aggressive in content it considers?
    • maybe "safer" due to unknowns of reset condition

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 14, 2022
@zvecr zvecr added in progress and removed stale Issues or pull requests that have become inactive without resolution. labels Oct 18, 2022
@tzarc tzarc closed this as completed Jan 3, 2023
@tzarc tzarc added this to XAP MVP Sep 25, 2023
@tzarc tzarc moved this to Done in XAP MVP Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement in progress xap XAP-related issues/PRs
Projects
Status: Done
Development

No branches or pull requests

2 participants