[Bug] Inconsistent MATRIX_COLS and MATRIX_COL_PINS. (KB: facew)

[elfmimi]

Describe the Bug

I was checking consistency of MATRIX_ROWS and MATRIX_COLS regarding the actual number of elements in MATRIX_ROW_PINS and MATRIX_COL_PINS respectively, for all keyboards.
And found out this in keyboards/facew/config.h.

#define MATRIX_COLS 11
#define MATRIX_COL_PINS { A0, A1, A2, A3, A4, A5, A6, A7, C7, C6}

I suppose above should have been written like this.
#define MATRIX_COL_PINS { A0, A1, A2, A3, A4, A5, A6, A7, C7, C6, C5 }

Can anyone provide certain information on this issue?
@mechmerlin

System Information

• Keyboard: facew
• QMK Firmware version: latest (0.7.140)

Additional Context

qmk_firmware/keyboards/facew/config.h

Lines 30 to 34 in 6a0e155

	#define MATRIX_ROWS 8
	#define MATRIX_COLS 11
	#define MATRIX_ROW_PINS { B0, B1, B2, B3, B4, B5, B6, B7 }
	#define MATRIX_COL_PINS { A0, A1, A2, A3, A4, A5, A6, A7, C7, C6}

[fauxpark]

Good catch. The entire first column of the layout macros is comprised of KC_NOs, so that can be eliminated, MATRIX_ROWS set to 10, and MATRIX_COL_PINS either left as is, or set to { A1, A2, A3, A4, A5, A6, A7, C7, C6, C5 } depending on which column that was meant to be.

[elfmimi]

Digging a bit into history, there can be found a clue. Before this commit it once was a custom matrix.
0231caa#diff-e7904ba5a8e04def4cd10c689415cfbaL69-L78

[elfmimi]

I guess this keyboard's circuit must be almost identical to schematics kept here.
https://github.com/showjean/ps2avrU/blob/master/firmware/ps2avrGB/Circuit/ps2avrGB/20140829_140848_001.png

[elfmimi]

Attached here is a list of keyboards which seems to share similar design which originates to b.face .
alike-of-b.face.txt

Closest to facew among those is bfake and the following is the diff between the two.

---bfake/config.h      2020-02-11 21:38:52.972852841 +0900
+++ facew/config.h      2020-02-19 16:21:03.262556524 +0900
@@ -26 +26 @@
-#define PRODUCT         b.fake
+#define PRODUCT         facew
@@ -34 +34 @@
-#define MATRIX_COL_PINS { A0, A1, A2, A3, A4, A5, A6, A7, C7, C6, C5 }
+#define MATRIX_COL_PINS { A0, A1, A2, A3, A4, A5, A6, A7, C7, C6}
@@ -44,2 +43,0 @@
-
-#define NO_UART 1

--- bfake/bfake.h       2018-10-23 02:04:13.237323982 +0900
+++ facew/facew.h       2020-02-19 16:21:03.262556524 +0900
@@ -18,2 +18 @@
-#ifndef BFAKE_H
-#define BFAKE_H
+#pragma once
@@ -26 +25 @@
-    K12, K21, K22, K23, K24, K34, K35, K25, K26, K27, K28, K38,   K40,      \
+    K12, K21, K22, K23, K24, K34, K35, K25, K26, K27, K28, K38, K48,  K40,  \
@@ -34 +33 @@
-  { KC_NO, K41,   K42,   K43,   K44, K45, K46,   K47,   KC_NO, K49,   K40},   \
+  { KC_NO, K41,   K42,   K43,   K44, K45, K46,   K47,   K48,   K49,   K40},   \
@@ -56,2 +54,0 @@
-
-#endif

note: K48 is the key next to right shift which is used to support ISO layout.