From 151d4bf7d0d4161dc66d4ac31f9527f49ed1fd87 Mon Sep 17 00:00:00 2001 From: Nathan13888 <29968201+Nathan13888@users.noreply.github.com> Date: Wed, 9 Dec 2020 23:04:14 -0500 Subject: [PATCH 1/3] YMD75 rev 3: fix BACKLIGHT_PIN Update backlight LED pin used by QMK to control the per-key backlight for YMD75 rev 3 --- keyboards/ymd75/rev3/config.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/keyboards/ymd75/rev3/config.h b/keyboards/ymd75/rev3/config.h index 6118b96b8b26..65daccc42298 100644 --- a/keyboards/ymd75/rev3/config.h +++ b/keyboards/ymd75/rev3/config.h @@ -4,6 +4,8 @@ #define MATRIX_COLS 9 #define MATRIX_ROW_PINS { B7, B3, B2, B1, B0, E6, F0, F1, F4, F5, F6, F7 } #define MATRIX_COL_PINS { D0, D1, D2, D3, D5, D4, D6, D7, B4 } +#undef BACKLIGHT_PIN // undefine the p +#define BACKLIGHT_PIN B6 // backlight pin has since changed in Rev 3 #define DIODE_DIRECTION ROW2COL #define DEVICE_VER 0x0300 #define RGBLIGHT_EFFECT_KNIGHT_OFFSET 4 From 502dd906a9c2c0a5452862bc2751e3d41a79885a Mon Sep 17 00:00:00 2001 From: Nathan13888 <29968201+Nathan13888@users.noreply.github.com> Date: Wed, 9 Dec 2020 23:10:58 -0500 Subject: [PATCH 2/3] YMD75 rev 3: fix BACKLIGHT_PIN - fix comments --- keyboards/ymd75/rev3/config.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/keyboards/ymd75/rev3/config.h b/keyboards/ymd75/rev3/config.h index 65daccc42298..d803be8bb192 100644 --- a/keyboards/ymd75/rev3/config.h +++ b/keyboards/ymd75/rev3/config.h @@ -4,8 +4,8 @@ #define MATRIX_COLS 9 #define MATRIX_ROW_PINS { B7, B3, B2, B1, B0, E6, F0, F1, F4, F5, F6, F7 } #define MATRIX_COL_PINS { D0, D1, D2, D3, D5, D4, D6, D7, B4 } -#undef BACKLIGHT_PIN // undefine the p -#define BACKLIGHT_PIN B6 // backlight pin has since changed in Rev 3 +#undef BACKLIGHT_PIN // undefine the macro set in /keyboards/ymd75/config.h +#define BACKLIGHT_PIN B6 // change the backlight pin that has since changed in Rev 3 #define DIODE_DIRECTION ROW2COL #define DEVICE_VER 0x0300 #define RGBLIGHT_EFFECT_KNIGHT_OFFSET 4 From c8bc883e426cf47120fa7af5f88bf89c2ac89fff Mon Sep 17 00:00:00 2001 From: Nathan13888 <29968201+Nathan13888@users.noreply.github.com> Date: Thu, 10 Dec 2020 13:40:47 -0500 Subject: [PATCH 3/3] YMD75: move BACKLIGHT_PIN definitions to the respective versions Signed-off-by: Nathan13888 <29968201+Nathan13888@users.noreply.github.com> --- keyboards/ymd75/config.h | 1 - keyboards/ymd75/rev1/config.h | 1 + keyboards/ymd75/rev2/config.h | 1 + keyboards/ymd75/rev3/config.h | 1 - 4 files changed, 2 insertions(+), 2 deletions(-) diff --git a/keyboards/ymd75/config.h b/keyboards/ymd75/config.h index 69102014fd00..cf3d3fd8dfb7 100644 --- a/keyboards/ymd75/config.h +++ b/keyboards/ymd75/config.h @@ -27,7 +27,6 @@ along with this program. If not, see . #define MANUFACTURER YMDK #define PRODUCT YMD75 / MT84 -#define BACKLIGHT_PIN D4 #define BACKLIGHT_LEVELS 12 #define RGB_DI_PIN E2 diff --git a/keyboards/ymd75/rev1/config.h b/keyboards/ymd75/rev1/config.h index d9796d9d72b2..bd169471af1d 100644 --- a/keyboards/ymd75/rev1/config.h +++ b/keyboards/ymd75/rev1/config.h @@ -24,5 +24,6 @@ along with this program. If not, see . #define MATRIX_COLS 15 #define MATRIX_ROW_PINS { B0, B1, B2, B3, B4, B5, B6, B7 } #define MATRIX_COL_PINS { A0, A1, A2, A3, A4, A5, A6, A7, C7, C6, C5, C4, C3, C2, D7 } +#define BACKLIGHT_PIN D4 #define DIODE_DIRECTION COL2ROW #define DEVICE_VER 0x0100 diff --git a/keyboards/ymd75/rev2/config.h b/keyboards/ymd75/rev2/config.h index a9578d720d20..41a75e62714e 100644 --- a/keyboards/ymd75/rev2/config.h +++ b/keyboards/ymd75/rev2/config.h @@ -5,5 +5,6 @@ #define MATRIX_COLS 15 #define MATRIX_ROW_PINS { B7, B6, B5, B4, B3, B0 } #define MATRIX_COL_PINS { A0, A1, A2, A3, A4, A5, A6, A7, C7, C6, C5, C4, C3, C2, D7 } +#define BACKLIGHT_PIN D4 #define DIODE_DIRECTION COL2ROW #define DEVICE_VER 0x0200 diff --git a/keyboards/ymd75/rev3/config.h b/keyboards/ymd75/rev3/config.h index d803be8bb192..cbed2e00eeeb 100644 --- a/keyboards/ymd75/rev3/config.h +++ b/keyboards/ymd75/rev3/config.h @@ -4,7 +4,6 @@ #define MATRIX_COLS 9 #define MATRIX_ROW_PINS { B7, B3, B2, B1, B0, E6, F0, F1, F4, F5, F6, F7 } #define MATRIX_COL_PINS { D0, D1, D2, D3, D5, D4, D6, D7, B4 } -#undef BACKLIGHT_PIN // undefine the macro set in /keyboards/ymd75/config.h #define BACKLIGHT_PIN B6 // change the backlight pin that has since changed in Rev 3 #define DIODE_DIRECTION ROW2COL #define DEVICE_VER 0x0300