Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YMD75 rev 3: fix BACKLIGHT_PIN #11172

Merged
merged 3 commits into from
Dec 22, 2020
Merged

YMD75 rev 3: fix BACKLIGHT_PIN #11172

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
151d4bf
YMD75 rev 3: fix BACKLIGHT_PIN
Nathan13888 Dec 10, 2020
502dd90
YMD75 rev 3: fix BACKLIGHT_PIN - fix comments
Nathan13888 Dec 10, 2020
c8bc883
YMD75: move BACKLIGHT_PIN definitions to the respective versions
Nathan13888 Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions keyboards/ymd75/rev3/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
#define MATRIX_COLS 9
#define MATRIX_ROW_PINS { B7, B3, B2, B1, B0, E6, F0, F1, F4, F5, F6, F7 }
#define MATRIX_COL_PINS { D0, D1, D2, D3, D5, D4, D6, D7, B4 }
#undef BACKLIGHT_PIN // undefine the p
#define BACKLIGHT_PIN B6 // backlight pin has since changed in Rev 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be better to move the original define out of the top level config.h, so that you don't have to undef here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, but then I didn't want to change the config.h in the keyboard/ymd75 directory to avoid any problems with rev 1 and rev 2 boards.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't, if you then add it back to the rev1 and rev2 config.h.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's kind of the point why I didn't do that because I can't verify that my changes to config.h in rev 1 and rev 2 would work. But I suppose it shouldn't break it; it's just one line anyways.

Alright, I'm going to submit another commit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it @fauxpark

#define DIODE_DIRECTION ROW2COL
#define DEVICE_VER 0x0300
#define RGBLIGHT_EFFECT_KNIGHT_OFFSET 4