From 4d8ba5a1daad1255e6052ec21836085892a4f82f Mon Sep 17 00:00:00 2001 From: duncanam <22781288+duncanam@users.noreply.github.com> Date: Sun, 30 Apr 2023 13:03:48 -0700 Subject: [PATCH 1/4] Adding alternative configs and update example --- keyboards/beekeeb/piantor/config.h | 3 +++ keyboards/beekeeb/piantor/no_vbus_sense/config.h | 1 + keyboards/beekeeb/piantor/no_vbus_sense/rules.mk | 0 keyboards/beekeeb/piantor/readme.md | 4 ++++ keyboards/beekeeb/piantor/weact/config.h | 2 ++ keyboards/beekeeb/piantor/weact/rules.mk | 0 6 files changed, 10 insertions(+) create mode 100644 keyboards/beekeeb/piantor/no_vbus_sense/config.h create mode 100644 keyboards/beekeeb/piantor/no_vbus_sense/rules.mk create mode 100644 keyboards/beekeeb/piantor/weact/config.h create mode 100644 keyboards/beekeeb/piantor/weact/rules.mk diff --git a/keyboards/beekeeb/piantor/config.h b/keyboards/beekeeb/piantor/config.h index e6ba4c0be932..e7e03fb4189b 100644 --- a/keyboards/beekeeb/piantor/config.h +++ b/keyboards/beekeeb/piantor/config.h @@ -10,3 +10,6 @@ #define SERIAL_USART_FULL_DUPLEX #define SERIAL_USART_TX_PIN GP0 #define SERIAL_USART_RX_PIN GP1 + +// When USB_VBUS_PIN is not defined, SPLIT_USB_DETECT is used. +#define USB_VBUS_PIN GP24 // for Raspberry Pi Pico \ No newline at end of file diff --git a/keyboards/beekeeb/piantor/no_vbus_sense/config.h b/keyboards/beekeeb/piantor/no_vbus_sense/config.h new file mode 100644 index 000000000000..b2fe3d5cd740 --- /dev/null +++ b/keyboards/beekeeb/piantor/no_vbus_sense/config.h @@ -0,0 +1 @@ +#undef USB_VBUS_PIN \ No newline at end of file diff --git a/keyboards/beekeeb/piantor/no_vbus_sense/rules.mk b/keyboards/beekeeb/piantor/no_vbus_sense/rules.mk new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/keyboards/beekeeb/piantor/readme.md b/keyboards/beekeeb/piantor/readme.md index 5171fd547e90..cd19d10f6efa 100644 --- a/keyboards/beekeeb/piantor/readme.md +++ b/keyboards/beekeeb/piantor/readme.md @@ -15,6 +15,10 @@ Make example for this keyboard (after setting up your build environment): Flashing example for this keyboard: make beekeeb/piantor:default:flash + +Flashing example for Weact, using Miryoku for the keymap: + + make beekeeb/piantor/weact:manna-harbour_miryoku:flash See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs). diff --git a/keyboards/beekeeb/piantor/weact/config.h b/keyboards/beekeeb/piantor/weact/config.h new file mode 100644 index 000000000000..57d96c8fc32f --- /dev/null +++ b/keyboards/beekeeb/piantor/weact/config.h @@ -0,0 +1,2 @@ +#undef USB_VBUS_PIN +#define USB_VBUS_PIN GP29 \ No newline at end of file diff --git a/keyboards/beekeeb/piantor/weact/rules.mk b/keyboards/beekeeb/piantor/weact/rules.mk new file mode 100644 index 000000000000..e69de29bb2d1 From 1e3d7ddb404d4d6fa361c1274f48aef22dde0672 Mon Sep 17 00:00:00 2001 From: duncanam <22781288+duncanam@users.noreply.github.com> Date: Wed, 5 Jul 2023 23:43:06 -0700 Subject: [PATCH 2/4] adding license and copyright to headers --- keyboards/beekeeb/piantor/no_vbus_sense/config.h | 3 +++ keyboards/beekeeb/piantor/weact/config.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/keyboards/beekeeb/piantor/no_vbus_sense/config.h b/keyboards/beekeeb/piantor/no_vbus_sense/config.h index b2fe3d5cd740..02772bc2ae4e 100644 --- a/keyboards/beekeeb/piantor/no_vbus_sense/config.h +++ b/keyboards/beekeeb/piantor/no_vbus_sense/config.h @@ -1 +1,4 @@ +// Copyright 2023 beekeeb +// SPDX-License-Identifier: GPL-2.0-or-later + #undef USB_VBUS_PIN \ No newline at end of file diff --git a/keyboards/beekeeb/piantor/weact/config.h b/keyboards/beekeeb/piantor/weact/config.h index 57d96c8fc32f..f38e9d7a582f 100644 --- a/keyboards/beekeeb/piantor/weact/config.h +++ b/keyboards/beekeeb/piantor/weact/config.h @@ -1,2 +1,5 @@ +// Copyright 2023 beekeeb +// SPDX-License-Identifier: GPL-2.0-or-later + #undef USB_VBUS_PIN #define USB_VBUS_PIN GP29 \ No newline at end of file From a0ce5a631455b033c49797fe0b7a52450bb91952 Mon Sep 17 00:00:00 2001 From: duncanam <22781288+duncanam@users.noreply.github.com> Date: Wed, 5 Jul 2023 23:50:19 -0700 Subject: [PATCH 3/4] adding example and docs link for no_vbus_sense --- keyboards/beekeeb/piantor/readme.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/keyboards/beekeeb/piantor/readme.md b/keyboards/beekeeb/piantor/readme.md index cd19d10f6efa..654039e6540d 100644 --- a/keyboards/beekeeb/piantor/readme.md +++ b/keyboards/beekeeb/piantor/readme.md @@ -19,6 +19,12 @@ Flashing example for this keyboard: Flashing example for Weact, using Miryoku for the keymap: make beekeeb/piantor/weact:manna-harbour_miryoku:flash + +To use the Weact RP2040 without the VBUS circuit, we can compile using SPLIT_USB_DETECT by not defining a USB VBUS pin: + + make beekeeb/piantor/no_vbus_sense:default:flash + +See more regarding VBUS sensing and QMK [HERE](https://docs.beekeeb.com/piantor-keyboard#vbus-sensing-and-qmk). See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs). From eb9309f1c1089077575d35306c1799a5ebf5dee8 Mon Sep 17 00:00:00 2001 From: duncanam <22781288+duncanam@users.noreply.github.com> Date: Sat, 15 Jul 2023 08:50:51 -0700 Subject: [PATCH 4/4] updating headers per review --- keyboards/beekeeb/piantor/no_vbus_sense/config.h | 1 + keyboards/beekeeb/piantor/weact/config.h | 1 + 2 files changed, 2 insertions(+) diff --git a/keyboards/beekeeb/piantor/no_vbus_sense/config.h b/keyboards/beekeeb/piantor/no_vbus_sense/config.h index 02772bc2ae4e..c8740bd791b8 100644 --- a/keyboards/beekeeb/piantor/no_vbus_sense/config.h +++ b/keyboards/beekeeb/piantor/no_vbus_sense/config.h @@ -1,4 +1,5 @@ // Copyright 2023 beekeeb // SPDX-License-Identifier: GPL-2.0-or-later +#pragma once #undef USB_VBUS_PIN \ No newline at end of file diff --git a/keyboards/beekeeb/piantor/weact/config.h b/keyboards/beekeeb/piantor/weact/config.h index f38e9d7a582f..a44627dd3081 100644 --- a/keyboards/beekeeb/piantor/weact/config.h +++ b/keyboards/beekeeb/piantor/weact/config.h @@ -1,5 +1,6 @@ // Copyright 2023 beekeeb // SPDX-License-Identifier: GPL-2.0-or-later +#pragma once #undef USB_VBUS_PIN #define USB_VBUS_PIN GP29 \ No newline at end of file