Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent color parameter controls give inconsistent results if websocket updates are slow #4

Open
SpComb opened this issue Apr 23, 2017 · 1 comment

Comments

@SpComb
Copy link
Member

SpComb commented Apr 23, 2017

For a head with RGB color controls, each of the RGB controls has its own independent component value. When each of those controls update, they use the most recent color parameter values updated by the server, not the values set by the other control components.

That means that adjusting two color controls will give the wrong color if the websocket does not update in between.

@SpComb
Copy link
Member Author

SpComb commented Apr 23, 2017

Fixed to keep local color state in the ColorControlComponent on changes, but that means that any external color updates from websocket events are ignored until the component is reloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant