Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect @psalm-internal #1021

Closed
vudaltsov opened this issue Nov 1, 2022 · 3 comments
Closed

Respect @psalm-internal #1021

vudaltsov opened this issue Nov 1, 2022 · 3 comments

Comments

@vudaltsov
Copy link

Relates to #904.

https://psalm.dev/docs/annotating_code/supported_annotations/#psalm-internal allows to specify a different namespace for an @internal class. Currently cannot update to deptrac >=0.21.1 due to this issue.

@patrickkusebauch
Copy link
Collaborator

And what is broken about this? What is the expected and actual behavior?

@vudaltsov
Copy link
Author

I started making a reproducer and realized that I didn't get this right:

If you do so, the marked class cannot be referenced by any class outside its layer

Thank you for this feature!

@dbrumann
Copy link
Collaborator

dbrumann commented Nov 3, 2022

Glad to hear, it solved itself. I will check your other issue for making internal checks configurable when I have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants