-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance counters to ConsoleSubsriber #1157
Comments
I could take this issue next week. As far as I checked, it seems to be enough to add a counter to I do not know if it would be useful to add a Is there anything else I should take into account? |
Looking at the implementation, please don't. It is not precise enough. use https://www.php.net/manual/en/function.hrtime.php. |
Okay, I will use I do not want to overengineer it, but I also do not want to create hard to maintain code. So tell me what you prefer :) |
I did this: d73d89a But feel free to do something more elaborate. |
It is nice that we inform users running in verbose mode as we are progressing, but we do not provide any numbers regarding how much time each part (Ast building, dependency resolution) takes.
Can we add some timers to
ConsoleSubsriber
that would give the user timing info about how long did it take between each step?The text was updated successfully, but these errors were encountered: