Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable FQCNs throw illegal offset warnings #124

Closed
hiddeco opened this issue Apr 28, 2017 · 1 comment
Closed

Nullable FQCNs throw illegal offset warnings #124

hiddeco opened this issue Apr 28, 2017 · 1 comment

Comments

@hiddeco
Copy link

hiddeco commented Apr 28, 2017

First of all, I introduced this bug myself in #122.

Nullable FQCNs currently throw lots of Illegal offset type in isset or empty warnings in the Astmap and ClassNameLayerResolverCacheDecorator because an object is passed as a class name which should be a string value.

The reason for this is that the NullableType::$type can either hold a string (as assumed in #122) or a FullyQualified node (as assumed before #122). The solution would be to check the type of NullableType::$type and take actions based on this type.

@timglabisch
Copy link
Collaborator

thanks =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants