Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 deprecations #839

Closed
alexander-schranz opened this issue Mar 14, 2022 · 2 comments · Fixed by #851
Closed

PHP 8.1 deprecations #839

alexander-schranz opened this issue Mar 14, 2022 · 2 comments · Fixed by #851

Comments

@alexander-schranz
Copy link
Contributor

Currently deprac seems to output some PHP 8.1 deprecations:

> @php vendor/bin/deptrac
PHP Deprecated:  Return type of HumbugBox3140\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/test/Documents/Projects/int3grate.localhost/vendor/qossmic/deptrac-shim/deptrac/.box/src/RequirementCollection.php on line 14

Deprecated: Return type of HumbugBox3140\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/test/Documents/Projects/int3grate.localhost/vendor/qossmic/deptrac-shim/deptrac/.box/src/RequirementCollection.php on line 14
PHP Deprecated:  Return type of HumbugBox3140\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/test/Documents/Projects/int3grate.localhost/vendor/qossmic/deptrac-shim/deptrac/.box/src/RequirementCollection.php on line 19

Deprecated: Return type of HumbugBox3140\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/test/Documents/Projects/int3grate.localhost/vendor/qossmic/deptrac-shim/deptrac/.box/src/RequirementCollection.php on line 19
PHP Deprecated:  Return type of HumbugBox3140\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/test/Documents/Projects/int3grate.localhost/vendor/qossmic/deptrac-shim/deptrac/.box/src/RequirementCollection.php on line 14

Deprecated: Return type of HumbugBox3140\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/test/Documents/Projects/int3grate.localhost/vendor/qossmic/deptrac-shim/deptrac/.box/src/RequirementCollection.php on line 14
PHP Deprecated:  Return type of HumbugBox3140\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/test/Documents/Projects/int3grate.localhost/vendor/qossmic/deptrac-shim/deptrac/.box/src/RequirementCollection.php on line 19

Deprecated: Return type of HumbugBox3140\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/test/Documents/Projects/int3grate.localhost/vendor/qossmic/deptrac-shim/deptrac/.box/src/RequirementCollection.php on line 19

I checked the box project and it seems to be fixed there: https://github.com/box-project/box/blob/3.16.0/requirement-checker/src/RequirementCollection.php Seems like deptrac was created with an older version of the box project?

@dbrumann
Copy link
Collaborator

Yes, I will do some tool updates before the next release

@alexander-schranz
Copy link
Contributor Author

@dbrumann thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants