[BUG] Toggle checkbox - checkbox where added in wrong place when autocreated from list

[wiktor2200]

Script name

Toggle checkbox

Script authors

@sanderboom @pbek

When providing list as in the example, with additional context added after - sigh it parses the list wrong.
Example:

test
test1
test - other
test2

Expected behavior

- [ ] test
- [ ] test1
- [ ] test - other
- [ ] test2

Actual behavior

- [ ] test
- [ ] test1
test - [ ] other
- [ ] test2

Steps to reproduce

Please use the script on provided example list.

Output from the debug section in the settings dialog

Not relevant.

Relevant log output in the Log panel

Not relevant.

[pbek]

Thank you for the fix!

[sanderboom]

👍

But now the following is broken..

Start with:

- test
	- test
	- test
		- test
	- some test
		- test
- test

Result with the change:

- [ ] test
- [ ] 	- test
- [ ] 	- test
- [ ] 		- test
- [ ] 	- some test
- [ ] 		- test
- [ ] test

Result before the change:

- [ ] test
	- [ ] test
	- [ ] test
		- [ ] test
	- [ ] some test
		- [ ] test
- [ ] test

🤔

Maybe it needs some more work 😃

[wiktor2200]

Hello @sanderboom!
Thanks a lot for pointing it out, good catch :) I haven't thought about this option before.
I've just prepared a fix for that.
@sanderboom @pbek Please take a look. #212

[pbek]

Checkbox creation works for be, but it doesn't seem to select the correct amount of text anymore:

It is done with script.noteTextEditSetSelection(noteTextEditSelectionStart, noteTextEditSelectionEnd);

[wiktor2200]

I think it's another issue. It has been there before.

Let's find if we understand ourselves correctly (I mark end of selection with # mark)
For this list:

- test
	- test
	- test
		- test
	- some test
		- test
- test

It returns (and returned):

- [ ] test
	- [ ] test
	- [ ] test
		- [ ] test
	- [ ] some # test
		- [ ] test
- [ ] test

Selection ends on first found white space. I've also checked on code before my changes ( git checkout 145fe71f1fb73d1821fb8640e3d1f0879dd66f87) and it behaves the same.

I think it may be connected with this comment https://github.com/qownnotes/scripts/blob/master/toggle-checkbox/toggle-checkbox.qml#L158 (5yrs ago), but maybe @sanderboom has some more insights?