feat(httpClient): introducing an httpClient #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arqu
added
feat
b5
reviewed
Feb 4, 2021
|
No comments aside from b5's feedback. |
Arqu
force-pushed
the
arqu/http_client
branch
from
02b0efe to
898b541
Compare
Arqu
force-pushed
the
arqu/http_client
branch
from
898b541 to
2c1ab39
Compare
b5
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards moving from RPC > HTTP.
So far this is non-breaking and simply introduces the HTTPClient and semi-defines the API endpoints we have.
Next series of PRs will convert us from RPC to the HTTPClient and funnel down the context from above to lib.
Also used the opportunity to update our ma/net package as the original one was deprecated and moved in as a subpackage.