fix(http.auth,qri.get_config): fix silly bugs from recent changes

qri-io · Jun 6, 2018 · 6f8ac60 · 6f8ac60
1 parent fc47343
commit 6f8ac60
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/lib/http/http.go b/lib/http/http.go
@@ -148,6 +148,7 @@ func setAuth(req *http.Request, auth skylark.Tuple) error {
 			return fmt.Errorf("parsing auth password string: %s", err.Error())
 		}
 		req.SetBasicAuth(username, password)
+		return nil
 	}
 	return fmt.Errorf("expected two values for auth params tuple")
 }

diff --git a/lib/qri/qri.go b/lib/qri/qri.go
@@ -44,12 +44,12 @@ func (m *Module) AddAllMethods(sd skylark.StringDict) skylark.StringDict {
 // GetConfig returns transformation configuration details
 // TODO - supplying a string argument to qri.get_config('foo') should return the single config value instead of the whole map
 func (m *Module) GetConfig(thread *skylark.Thread, _ *skylark.Builtin, args skylark.Tuple, kwargs []skylark.Tuple) (skylark.Value, error) {
-	if m.secrets == nil {
+	if m.ds.Transform.Config == nil {
 		return skylark.None, nil
 	}
 
 	var keyx skylark.Value
-	if err := skylark.UnpackPositionalArgs("get_secret", args, kwargs, 1, &keyx); err != nil {
+	if err := skylark.UnpackPositionalArgs("get_config", args, kwargs, 1, &keyx); err != nil {
 		return nil, err
 	}
 

diff --git a/lib/qri/testdata/test.sky b/lib/qri/testdata/test.sky
@@ -1,3 +1,3 @@
 load('qri.sky', 'qri')
 
-cfg = qri.get_config()
+foo = qri.get_config("foo")