Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): release v0.4.0 #28

Merged
merged 5 commits into from
Jun 3, 2019
Merged

chore(release): release v0.4.0 #28

merged 5 commits into from
Jun 3, 2019

Conversation

ramfox
Copy link
Member

@ramfox ramfox commented May 29, 2019

adds go.mod file
edits go.mod file to import the correct versions
updates CHANGELOG.md
fixes xlsx bug
fixes math package test bug

ramfox added 2 commits May 30, 2019 13:48
…r.star`

we use the `assert.star` file for testing purposes. We need to load it in a bunch of different places, so lets create a package that all the testing functions can pull from.
@ramfox ramfox requested a review from b5 June 3, 2019 15:55
Copy link
Member

@b5 b5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOPE LGTM

// takes a LoadModule function
// a ModuleName
// and the relative path to the testdata
func NewLoader(loader func() (starlark.StringDict, error), moduleName string) func(thread *starlark.Thread, module string) (starlark.StringDict, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@b5
Copy link
Member

b5 commented Jun 3, 2019

I added a commit that pushes some details to CHANGELOG.md, just 'cause this one actually has a proper release history

@ramfox ramfox merged commit fc36d71 into master Jun 3, 2019
@ramfox ramfox deleted the 0.4.0 branch June 3, 2019 16:15
@b5
Copy link
Member

b5 commented Jun 3, 2019

this part of the qri-io/qri#726 mission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants