Add option for two-letter language codes in language widget

[herrvigg]

Issue by benique
Tuesday Aug 04, 2015 at 14:07 GMT
Originally opened as qTranslate-Team/qtranslate-x#208

---

It would be nice to have the option to display the short codes in the language menu.

---

benique included the following code: https://github.com/qTranslate-Team/qtranslate-x/pull/208/commits

[herrvigg]

Comment by johnclause
Saturday Aug 08, 2015 at 02:21 GMT

---

Yes, this is a good idea, @benique, thank you! I do not see a code in your PR, where the shortcodes are executed. Could you explain a bit more details how you envision this?

[herrvigg]

Comment by benique
Saturday Aug 08, 2015 at 07:03 GMT

---

What I meant is, it should be possible to display the two letter language short codes (ISO 639-1) in the menu instead of the names. So let's say someone has a website in English an German. Then menu would then look Like this:
en de
I know there is an option to set different labels for the languages but then it also changes the language display in other areas on the website and backend.
The wordpress shortcodes might be another issue i can look into.

[herrvigg]

Comment by benique
Wednesday Aug 12, 2015 at 18:08 GMT

---

@johnclause Can I change anything to make it better?
I will create a separate pull request for the implementation of shortcodes.

[herrvigg]

Comment by johnclause
Thursday Sep 17, 2015 at 04:48 GMT

---

Could you add this option to Widget configuration form in function qTranslateXWidget with proper help text? I am not sure about the name 'short', it seems confusing to me, at first glance. Maybe 'lang_code'? I guess it gets better after a while, on the second though 'short' now seems fine. I do not know, if you like 'short', leave it - help text matters the most anyway.

[herrvigg]

Comment by benique
Thursday Sep 17, 2015 at 16:56 GMT

---

@johnclause Thanks for your help. I updated the widget.

[herrvigg]

Comment by johnclause
Thursday Sep 17, 2015 at 17:03 GMT

---

Something is probably not right, I do not see new changes?

[herrvigg]

Comment by benique
Thursday Sep 17, 2015 at 17:09 GMT

---

I made changes on the following lines:
59, 107
https://github.com/benique/qtranslate-x/blob/master/qtranslate_widget.php

Did I miss anything?

[herrvigg]

Comment by johnclause
Thursday Sep 17, 2015 at 17:18 GMT

---

Wow, now I see the changes... I guess the browser needed to be refreshed ... Thanks a lot!

[herrvigg]

Comment by johnclause
Thursday Sep 17, 2015 at 17:40 GMT

---

It shows flag image too, is this how you wished it?

[herrvigg]

Comment by benique
Thursday Sep 17, 2015 at 17:47 GMT

---

no. It should only show the iso code

[herrvigg]

Comment by johnclause
Thursday Sep 17, 2015 at 17:49 GMT

---

That means that you customized CSS in your case at the same time?

We are trying to follow the old logic, but with that many options already it does not really fit anymore. What would probably work nicely now is an arbitrary format string like "%lang_flag% %lang_name% %lang_code%". I can see people may like to do something like "%lang_flag% %lang_name% (%lang_code%)". In your case, you would enter "%lang_code%" only. This way people may add additional CSS codes right in the format string too.

What do you think, is that something people would value?

[herrvigg]

Comment by benique
Thursday Sep 17, 2015 at 17:58 GMT

---

I don't see any flags on my page.
http://www.pureco-led.com

I couldn't find anything in the css code either. I'm using the qTranslate-X 3.4.4 with this code block:

    case 'short':
        echo PHP_EOL.'<ul class="qtranxs_language_chooser" id="'.$id.'">'.PHP_EOL;
        foreach(qtranxf_getSortedLanguages() as $language) {
            echo '<li';
            if($language == $q_config['language'])
                echo ' class="active"';
            echo '><a href="'.qtranxf_convertURL($url, $language, false, true).'"';
            echo ' class="qtranxs_flag_'.$language.' qtranxs_flag_and_text" title="'.$q_config['language_name'][$language].'">';
            echo '<span>'.$language.'</span></a></li>'.PHP_EOL;
        }
        echo '</ul><div class="qtranxs_widget_end"></div>'.PHP_EOL;
        break;

Yeah that would be good for advanced users. We would need to preserve backwards compatibility though.

[herrvigg]

Comment by johnclause
Thursday Sep 17, 2015 at 18:15 GMT

---

@benique: I do not know, classes 'qtranxs_flag_'.$language.' qtranxs_flag_and_text' show flag on background by default, unless you customized it via "Widget CSS", or advanced option "Head inline CSS", or your own CSS.

@HowToSolutions: what do you think about format option? Your case, css_only would then have simply empty format? Would it make sense to you?

You both are "advanced" users, since nobody else requested your cases ;)

[herrvigg]

Comment by benique
Thursday Sep 17, 2015 at 18:41 GMT

---

I just tested the newest version of the plugin from github again without the css of my custom theme. It still didn't show any flags. I just found out, it's because I disabled the option to add CSS code to the header in the settings.

I think it would be cumbersome to do everything with css. Adding an additional language would always mean that you have to edit the css code.

Your suggestion with the placeholders looks very good. I think that would be the way to go.

[herrvigg]

Comment by johnclause
Thursday Sep 17, 2015 at 18:44 GMT

---

Adding an additional language would always mean that you have to edit the css code

Only if you wish to customize it, the default gets auto-adjusted on language list change.

[herrvigg]

Comment by johnclause
Monday Oct 05, 2015 at 01:51 GMT

---

@benique, @HowToSolutions: The latest version at GitHub has code for custom format in widget, which should work for both of you, as well as for future improvements. Please, test it all as much as possible, not only this problem, but all the features you use, before we release it. Thank you very much.

[herrvigg]

Comment by benique
Monday Oct 05, 2015 at 08:49 GMT

---

@johnclause That's great. I would however not add any static html code. That way one could do stuff like this:

<div class="lang-menu">
   <?php echo qtranxf_generateLanguageSelectCode('<a href="%link" class="%classes" title="%language">%l</a>'); ?>
</div>

or

<div class="lang-menu">
   <?php echo qtranxf_generateLanguageSelectCode('<a href="%link" class="%classes" title="%language" style="background-image:url(%image); background-size:cover; background-position: center center; width: 20px; height: 20px"></a>'); ?>
</div>

I would change the names of the variables as well to make it more clear what they stand for.

%l        -> 2 letter language code
%language -> language name
%image    -> flag
%link     -> link to translated page
%classes -> qTranslate-X classes

Those changes could make it very powerful.

A very good alternative would be to just output an array with all the variables. That would be the most flexible option and require very little effort from our side.

[herrvigg]

Comment by johnclause
Friday Oct 09, 2015 at 00:43 GMT

---

@benique: I added arguments %s for the URL of flag, and %a for language name in active language, since they are now available due to your efforts 👍

Please, download the latest version to try.

As to "%classes", I think, having classes in "

" already provides an opportunity to setup CSS in any desirable way for the items under "

", then "%classes" seems to be excessive.

List items have the format

<li class="..."><a href="link" title="native_language_name">[content]</a></li>

and only "[content]" part is what provided with 'format', which should not have '%link' either.

Your examples are achievable after I added argument %s for flag URL, can you see it? For example, your second case:

<div class="lang-menu">
<?php echo qtranxf_generateLanguageSelectCode(array('type'=>'custom', 'format' => '<span style="background-image:url(%s); background-size:cover; background-position: center center; width: 20px; height: 20px></span>'); ?>
</div>

What do you think?

[herrvigg]

Comment by benique
Friday Oct 09, 2015 at 06:58 GMT

---

@johnclause It's great that you made it more flexible.

In my opinion most use cases are covered now by the other menu types. So the other cases might require a html structure that we haven't thought about. Those who have different requirements are most likely very fluent in HTML & PHP and won't mind having to write more code.

Therefore I would make the custom option as flexible as possible or just return an array with all necessary infos.

[herrvigg]

Comment by johnclause
Friday Oct 09, 2015 at 15:33 GMT

---

I still do not see a reason to customize <li> and <a>, since it is already customizable with CSS trough classes in <li>, is that correct? Could you give me an example of what you cannot do with the current custom option?

Yes, if a user is advanced and fluent with PHP, then it might be easier to make a copy of the function and adjust it to do whatever one wants.

[herrvigg]

Comment by benique
Monday Oct 12, 2015 at 10:04 GMT

---

It certainly covers most use cases. So le'ts leave it like that then.

[herrvigg]

Comment by dademaru
Thursday Sep 22, 2016 at 15:07 GMT

---

@johnclause
Isn't it possible to implement 'dropdown' + 'short' (language code)?
Dropdown is useful since it takes up little space, for example in menus, menu bars.
It might be even more helpful if instead of showing the full languages names, only show the language code.
It would be great if we can choose short style for dropdown options labels in qtranxf_generateLanguageSelectCode.
Maybe making hookable a $language_label variable instead of using directly $q_config['language_name'][$language], so user could decide to pass $language (code) or leave $q_config['language_name'][$language].
In addition, 'text' and 'short' cases would become a unique case, using only $language_label variable.

Thanks