Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACF post object titles not translated #677

Closed
hencca opened this issue Apr 29, 2019 · 3 comments
Closed

ACF post object titles not translated #677

hencca opened this issue Apr 29, 2019 · 3 comments
Labels
module: ACF Integration with ACF

Comments

@hencca
Copy link
Contributor

hencca commented Apr 29, 2019 •
edited
Loading

I've was able to fix this with the following pull request, but I'm not familiar with HerrVigg's thinking, so there are surely other considerations. Not sure why we need the filrer qtranxf_admin_the_title

#678
@hencca
Copy link
Contributor Author

hencca commented Apr 29, 2019

image

@herrvigg herrvigg changed the title ACF post object tiles not tanlated in admin area ACF post object titles not translated in admin area Jun 26, 2019
@herrvigg herrvigg added the plugin: others Concerns integration with other plugins label Jun 26, 2019
@herrvigg
Copy link
Collaborator

All right it took me a bit of time to test this with ACF but i managed to reproduce it. Follow-up in PR #678.

@herrvigg herrvigg changed the title ACF post object titles not translated in admin area ACF post object titles not translated Jun 26, 2019
@herrvigg
Copy link
Collaborator

herrvigg commented Jul 3, 2019

Tested with ACF and PR #678 merged in master. It works with no regression for the nav menus (add & update)!

@herrvigg herrvigg closed this as completed Jul 3, 2019
@herrvigg herrvigg added module: ACF Integration with ACF and removed plugin: others Concerns integration with other plugins labels Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: ACF Integration with ACF
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hencca @herrvigg