Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixup emailRem and inquiryPerson.email #2 #192

Closed
jensstalder opened this issue Sep 30, 2021 · 1 comment · Fixed by #197
Closed

Mixup emailRem and inquiryPerson.email #2 #192

jensstalder opened this issue Sep 30, 2021 · 1 comment · Fixed by #197
Assignees

Comments

@jensstalder
Copy link
Collaborator

jensstalder commented Sep 30, 2021

I am not quite sure why that emailRem exists on the organization level in the first place. Better would be that we add inquiryPerson to the project level.

We should have project.inquiryPerson instead of emailRem

<xs:complexType name="organization">
    <xs:all>
      <xs:element name="address" type="address" minOccurs="0" maxOccurs="1" />
      <xs:element type="xs:string" name="legalName" minOccurs="0" maxOccurs="1" />
      <xs:element type="xs:string" name="brand" minOccurs="0" maxOccurs="1" />
      <xs:element type="emailaddress" name="email" minOccurs="0" maxOccurs="1" />
      <xs:element type="emailaddress" name="emailRem" minOccurs="0" maxOccurs="1" /> <!-- here -->
      <xs:element type="phoneNumber" name="phone" minOccurs="0" maxOccurs="1" />
      <xs:element type="phoneNumber" name="mobile" minOccurs="0" maxOccurs="1" />
      <xs:element name="website" minOccurs="0" maxOccurs="1">
        <xs:annotation>
          <xs:documentation>Sellers URL, typically the company website.</xs:documentation>
        </xs:annotation>
        <xs:complexType>
          <xs:simpleContent>
            <xs:extension base="xs:anyURI">
              <xs:attribute type="xs:string" name="title" />
              <xs:attribute type="xs:string" name="label" />
            </xs:extension>
          </xs:simpleContent>
        </xs:complexType>
      </xs:element>
    </xs:all>
    <xs:attribute type="xs:string" name="id" use="optional" />
  </xs:complexType>
@jensstalder
Copy link
Collaborator Author

After some discussion the following plan was discussed

  1. We will create a PR that adds the "inquiryPerson" to the project level and adds a depreciation notice for the "emailRem" field. This way nothing breaks but we have the opportunity of using the intended "inquiryPerson" for this functionality.
  2. Later on when the next major version (Probably 3.0.0) comes out we will try to eliminate or discourage the usage of the "emailRem" field entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant