Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to rate limit after X errors in X minutes #11

Open
tikotzky opened this issue Feb 1, 2016 · 4 comments
Open

add ability to rate limit after X errors in X minutes #11

tikotzky opened this issue Feb 1, 2016 · 4 comments

Comments

@tikotzky
Copy link
Member

tikotzky commented Feb 1, 2016

slack will disable the integration if it starts sending too many errors too quickly
see: https://api.slack.com/docs/rate-limits

we should probably add an option to which allows you to specify the max messages/time and it should auto rate limit once that limit is reached.

@tikotzky
Copy link
Member Author

tikotzky commented Feb 1, 2016

@eligolding wanna take a crack at this?

@tikotzky
Copy link
Member Author

tikotzky commented Feb 1, 2016

idea would be to throttle this call so we dont end up clobbering slack if something goes 💣

@gictor
Copy link

gictor commented Feb 15, 2017

We had some issues with this causing our application to hogg all the memories. Suggested fix

64ca7b9

@gictor
Copy link

gictor commented Feb 16, 2017

I saw that the automatic tests didn't go through, now its backwards compatible #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants