Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flake in test_create_gate_set_validator #4796

Closed
95-martin-orion opened this issue Jan 4, 2022 · 2 comments
Closed

Flake in test_create_gate_set_validator #4796

95-martin-orion opened this issue Jan 4, 2022 · 2 comments
Assignees
@dstrain115
Labels
area/gatesets kind/bug-report Something doesn't seem to work. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@95-martin-orion
Copy link
Collaborator

Description of the issue
cirq-google/cirq_google/engine/engine_validator_test.py::test_create_gate_set_validator experiences a flake in ~0.4% of tests where the generated circuit is too long. Example failure

How to reproduce the issue

pip install pytest-repeat
pytest cirq-google/cirq_google/engine/engine_validator_test.py -k create_gate_set -p no:warnings --count=1000
# ~0.4% flake with "RuntimeError: INVALID_PROGRAM: Program too long."

Cirq version

0.14.0.dev
@95-martin-orion 95-martin-orion added the kind/bug-report Something doesn't seem to work. label Jan 4, 2022
@95-martin-orion 95-martin-orion mentioned this issue Jan 4, 2022
Merged
@viathor viathor added area/gatesets triage/discuss Needs decision / discussion, bring these up during Cirq Cynque labels Jan 12, 2022
@tanujkhattar
Copy link
Collaborator

From cirq sync:

This is testing that really large circuits are invalidated. We should make the test deterministic to fix this. The test needs to be there.

@tanujkhattar tanujkhattar added triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on and removed triage/discuss Needs decision / discussion, bring these up during Cirq Cynque labels Jan 26, 2022
@dstrain115
Copy link
Collaborator

This was fixed in #4908.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dstrain115 dstrain115

Labels
area/gatesets kind/bug-report Something doesn't seem to work. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dabacon @tanujkhattar @dstrain115 @viathor @95-martin-orion