Caching value_equality_values? #6272
Labels
area/performance
good first issue
This issue can be resolved by someone who is not familiar with the codebase. A good starting issue.
no QC knowledge needed
Want to contribute to Cirq, but don't know quantum computing? This issue is for you.
triage/accepted
A consensus emerged that this bug report, feature request, or other action should be worked on
Is your feature request related to a use case or problem? Please describe.
Are we "allowed" to cache the
_value_equality_values
? If so, is there a standard way to do this?I'm in particular looking at PhasedXZGate:
Cirq/cirq-core/cirq/ops/phased_x_z_gate.py
Line 123 in b28bfce
Describe the solution you'd like
I suppose decorating with
@_compat.cached_method
would be the easiest thing.[optional] Describe alternatives/workarounds you've considered
[optional] Additional context (e.g. screenshots)
What is the urgency from your perspective for this issue? Is it blocking important work?
P1 - I need this no later than the next release (end of quarter)
The text was updated successfully, but these errors were encountered: